All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alok Kataria <akataria@vmware.com>
To: Glauber Costa <glommer@redhat.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mingo@elte.hu" <mingo@elte.hu>,
	"avi@redhat.com" <avi@redhat.com>,
	Glauber Costa <gcosta@redhat.com>
Subject: Re: [PATCH 1/2] show hypervisor information on cpuinfo
Date: Thu, 05 Feb 2009 10:53:07 -0800	[thread overview]
Message-ID: <1233859987.29693.9.camel@alok-dev1> (raw)
In-Reply-To: <1233859341-10419-2-git-send-email-glommer@redhat.com>

I am all for it.

Just one nit, below.

>  
> +char * __cpuinit hypervisor_str(struct cpuinfo_x86 *c)
> +{
> +	if (c->x86_hyper_vendor == X86_HYPER_VENDOR_VMWARE)
> +		return "VMWare";

Better to have "VMware" string instead.

Thanks,
Alok


  parent reply	other threads:[~2009-02-05 18:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05 18:42 [PATCH 0/2] expose hypervisor information on cpuid Glauber Costa
2009-02-05 18:42 ` [PATCH 1/2] show hypervisor information on cpuinfo Glauber Costa
2009-02-05 18:42   ` [PATCH 2/2] tell cpuinfo if we're running on top of KVM Glauber Costa
2009-02-05 18:53   ` Alok Kataria [this message]
2009-02-05 19:02   ` [PATCH 1/2] show hypervisor information on cpuinfo Ingo Molnar
2009-02-05 19:05     ` Chris Wright
2009-02-05 19:08     ` Anthony Liguori
2009-02-05 18:52 ` [PATCH 0/2] expose hypervisor information on cpuid Chris Wright
2009-02-05 19:04   ` Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233859987.29693.9.camel@alok-dev1 \
    --to=akataria@vmware.com \
    --cc=avi@redhat.com \
    --cc=gcosta@redhat.com \
    --cc=glommer@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.