All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Ingo Molnar <mingo@elte.hu>
Cc: Glauber Costa <glommer@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	avi@redhat.com, akataria@vmware.com,
	Glauber Costa <gcosta@redhat.com>
Subject: Re: [PATCH 1/2] show hypervisor information on cpuinfo
Date: Thu, 05 Feb 2009 13:08:03 -0600	[thread overview]
Message-ID: <498B3913.2010701@codemonkey.ws> (raw)
In-Reply-To: <20090205190250.GE20470@elte.hu>

Ingo Molnar wrote:
> * Glauber Costa <glommer@redhat.com> wrote:
>
>   
>> +char * __cpuinit hypervisor_str(struct cpuinfo_x86 *c)
>> +{
>> +	if (c->x86_hyper_vendor == X86_HYPER_VENDOR_VMWARE)
>> +		return "VMWare";
>> +	else
>> +		return "none";
>> +}
>>     
>
> i'd suggest these variants instead:
>
>  virtualization:	native kernel
>   

I don't think "native kernel" really ports well to other architectures 
(like s390 or PPC) that always have hypervisors present in some form.  I 
think "none" makes more sense in the case of bare metal x86.

Regards,

Anthony Liguori

>  virtualization:	KVM guest
>  virtualization:	VMWare guest
>  virtualization:	Linux guest
>
> 	Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>   


  parent reply	other threads:[~2009-02-05 19:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05 18:42 [PATCH 0/2] expose hypervisor information on cpuid Glauber Costa
2009-02-05 18:42 ` [PATCH 1/2] show hypervisor information on cpuinfo Glauber Costa
2009-02-05 18:42   ` [PATCH 2/2] tell cpuinfo if we're running on top of KVM Glauber Costa
2009-02-05 18:53   ` [PATCH 1/2] show hypervisor information on cpuinfo Alok Kataria
2009-02-05 19:02   ` Ingo Molnar
2009-02-05 19:05     ` Chris Wright
2009-02-05 19:08     ` Anthony Liguori [this message]
2009-02-05 18:52 ` [PATCH 0/2] expose hypervisor information on cpuid Chris Wright
2009-02-05 19:04   ` Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498B3913.2010701@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=akataria@vmware.com \
    --cc=avi@redhat.com \
    --cc=gcosta@redhat.com \
    --cc=glommer@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.