Re: grub-probe detects ext4 wronly as ext2

[Felix Zielcke <fzielcke@z-51.de>]

Am Mittwoch, den 04.02.2009, 14:08 +0100 schrieb Javier Martín:

> Well, I am happy to post a diff of the patch against current SVN head
> (r1973). I have personally confirmed (in a VM) that it:
> 1) Still builds (and even runs! ^^)
> 2) Works with existing ext2/3 file systems (I haven't checked ext4 FSs
> but the "extents" bit is marked as supported, so it should work)
> 3) Correctly rejects journal devices, which will then appear as "unknown
> filesystem" when accessed.

FLEX_BG needs to be added to the list of ignored flags.
As Robert already said in his last reply to this thread [0]

const char *local_error = 0;
Please use NULL.

 +    EXT2_DRIVER_MOUNT_FAIL(0);

I share his opinion that this isn't needed.

If you fix this and write a changelog then I commit this.

[0] http://lists.gnu.org/archive/html/grub-devel/2008-08/msg00645.html
-- 
Felix Zielcke