All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: Sachin Sant <sachinp@in.ibm.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: Next 12 : arch/powerpc/sysdev/axonram build failure
Date: Thu, 12 Mar 2009 23:16:27 +1100	[thread overview]
Message-ID: <1236860187.12893.5.camel@localhost> (raw)
In-Reply-To: <49B8C7FA.8090805@in.ibm.com>

On Thu, 2009-03-12 at 13:59 +0530, Sachin Sant wrote:
> Hi Stephen,
> 
> Today's next randconfig build on powerpc fails with
> 
>   CC [M]  arch/powerpc/sysdev/axonram.o
> arch/powerpc/sysdev/axonram.c:108: warning: ‘struct request_queue’ declared inside parameter list
> arch/powerpc/sysdev/axonram.c:108: warning: its scope is only this definition or declaration, which is probably not what you want
> arch/powerpc/sysdev/axonram.c: In function ‘axon_ram_make_request’:
<snip>
> arch/powerpc/sysdev/axonram.c:289: error: implicit declaration of function ‘unregister_blkdev’
> arch/powerpc/sysdev/axonram.c:289: error: dereferencing pointer to incomplete type
> arch/powerpc/sysdev/axonram.c:290: error: dereferencing pointer to incomplete type
> arch/powerpc/sysdev/axonram.c:291: error: implicit declaration of function ‘del_gendisk’
> arch/powerpc/sysdev/axonram.c: In function ‘axon_ram_init’:
> arch/powerpc/sysdev/axonram.c:345: error: implicit declaration of function ‘register_blkdev’
> make[1]: *** [arch/powerpc/sysdev/axonram.o] Error 1
> make: *** [arch/powerpc/sysdev] Error 2
> 
> CONFIG_BLOCK is not set.

So how about this:

>From 7325aea8244ac83d98cde7a509ec8ab5994cdb0e Mon Sep 17 00:00:00 2001
From: Michael Ellerman <michael@ellerman.id.au>
Date: Thu, 12 Mar 2009 23:14:58 +1100
Subject: [PATCH] powerpc/cell: axonram depends on BLOCK

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
 arch/powerpc/platforms/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
index b4ab372..3fb0851 100644
--- a/arch/powerpc/platforms/Kconfig
+++ b/arch/powerpc/platforms/Kconfig
@@ -266,7 +266,7 @@ config CPM2
 
 config AXON_RAM
 	tristate "Axon DDR2 memory device driver"
-	depends on PPC_IBM_CELL_BLADE
+	depends on PPC_IBM_CELL_BLADE && BLOCK
 	default m
 	help
 	  It registers one block device per Axon's DDR2 memory bank found
-- 
1.6.1.2



_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <michael@ellerman.id.au>
To: Sachin Sant <sachinp@in.ibm.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: Next 12 : arch/powerpc/sysdev/axonram build failure
Date: Thu, 12 Mar 2009 23:16:27 +1100	[thread overview]
Message-ID: <1236860187.12893.5.camel@localhost> (raw)
In-Reply-To: <49B8C7FA.8090805@in.ibm.com>

On Thu, 2009-03-12 at 13:59 +0530, Sachin Sant wrote:
> Hi Stephen,
> 
> Today's next randconfig build on powerpc fails with
> 
>   CC [M]  arch/powerpc/sysdev/axonram.o
> arch/powerpc/sysdev/axonram.c:108: warning: ‘struct request_queue’ declared inside parameter list
> arch/powerpc/sysdev/axonram.c:108: warning: its scope is only this definition or declaration, which is probably not what you want
> arch/powerpc/sysdev/axonram.c: In function ‘axon_ram_make_request’:
<snip>
> arch/powerpc/sysdev/axonram.c:289: error: implicit declaration of function ‘unregister_blkdev’
> arch/powerpc/sysdev/axonram.c:289: error: dereferencing pointer to incomplete type
> arch/powerpc/sysdev/axonram.c:290: error: dereferencing pointer to incomplete type
> arch/powerpc/sysdev/axonram.c:291: error: implicit declaration of function ‘del_gendisk’
> arch/powerpc/sysdev/axonram.c: In function ‘axon_ram_init’:
> arch/powerpc/sysdev/axonram.c:345: error: implicit declaration of function ‘register_blkdev’
> make[1]: *** [arch/powerpc/sysdev/axonram.o] Error 1
> make: *** [arch/powerpc/sysdev] Error 2
> 
> CONFIG_BLOCK is not set.

So how about this:

>From 7325aea8244ac83d98cde7a509ec8ab5994cdb0e Mon Sep 17 00:00:00 2001
From: Michael Ellerman <michael@ellerman.id.au>
Date: Thu, 12 Mar 2009 23:14:58 +1100
Subject: [PATCH] powerpc/cell: axonram depends on BLOCK

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
 arch/powerpc/platforms/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
index b4ab372..3fb0851 100644
--- a/arch/powerpc/platforms/Kconfig
+++ b/arch/powerpc/platforms/Kconfig
@@ -266,7 +266,7 @@ config CPM2
 
 config AXON_RAM
 	tristate "Axon DDR2 memory device driver"
-	depends on PPC_IBM_CELL_BLADE
+	depends on PPC_IBM_CELL_BLADE && BLOCK
 	default m
 	help
 	  It registers one block device per Axon's DDR2 memory bank found
-- 
1.6.1.2

  reply	other threads:[~2009-03-12 12:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-12  6:11 linux-next: Tree for March 12 Stephen Rothwell
2009-03-12  8:29 ` Next 12 : arch/powerpc/sysdev/axonram build failure Sachin Sant
2009-03-12  8:29   ` Sachin Sant
2009-03-12 12:16   ` Michael Ellerman [this message]
2009-03-12 12:16     ` Michael Ellerman
2009-03-12 13:01     ` Sachin Sant
2009-03-12 13:01       ` Sachin Sant
2009-03-13 10:35 ` Kernel panic on linux-nextMarch 12 Nico -telmich- Schottelius
2009-03-14 13:11 ` linux-next: Tree for March 12 (tty) Bartlomiej Zolnierkiewicz
2009-03-14 14:19   ` Alan Cox
2009-03-14 16:54   ` Alan Cox
2009-03-15 13:42     ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1236860187.12893.5.camel@localhost \
    --to=michael@ellerman.id.au \
    --cc=linux-next@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sachinp@in.ibm.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.