From: Lubomir Rintel <lkundrak@v3.sk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: linux-sound@vger.kernel.org, Krzysztof Helt <krzysztof.h1@wp.pl>,
stable@kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Fix NULL dereference when suspending snd_opl3sa2
Date: Mon, 16 Mar 2009 14:16:08 +0000 [thread overview]
Message-ID: <1237212968.11067.3.camel@localhost.localdomain> (raw)
In-Reply-To: <1237197709.7210.2.camel@localhost.localdomain>
On Mon, 2009-03-16 at 11:01 +0100, Lubomir Rintel wrote:
> This should fix the following OOPS:
> http://www.kerneloops.org/raw.php?rawid€591&msgid
Wrong, sorry, the disassembly from kerneloops was a bit confusing to me.
Looking at the disassembly of the actual module:
> @@ -553,7 +553,8 @@ static int snd_opl3sa2_suspend(struct snd_card
> *card, pm_message_t state)
> struct snd_opl3sa2 *chip = card->private_data;
card must somehow be NULL here:
00000270 <snd_opl3sa2_suspend>:
270: 53 push %ebx
271: 8b 98 38 01 00 00 mov 0x138(%eax),%ebx
277: b9 01 00 00 00 mov $0x1,%ecx
27c: ba 03 00 00 00 mov $0x3,%edx
281: c7 80 a8 01 00 00 00 movl $0x300,0x1a8(%eax)
288: 03 00 00
28b: 05 bc 01 00 00 add $0x1bc,%eax
290: 6a 00 push $0x0
292: e8 fc ff ff ff call 293 <snd_opl3sa2_suspend+0x23>
297: 8b 53 24 mov 0x24(%ebx),%edx
29a: 89 d0 mov %edx,%eax
29c: ff 92 d4 00 00 00 call *0xd4(%edx)
2a2: 89 d8 mov %ebx,%eax
2a4: b9 27 00 00 00 mov $0x27,%ecx
2a9: ba 01 00 00 00 mov $0x1,%edx
2ae: e8 72 fe ff ff call 125 <snd_opl3sa2_write>
2b3: 58 pop %eax
2b4: 31 c0 xor %eax,%eax
2b6: 5b pop %ebx
2b7: c3 ret
This is the same issue, with 2.6.28:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bugQ9939
WARNING: multiple messages have this Message-ID (diff)
From: Lubomir Rintel <lkundrak@v3.sk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: linux-sound@vger.kernel.org, Krzysztof Helt <krzysztof.h1@wp.pl>,
stable@kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Fix NULL dereference when suspending snd_opl3sa2
Date: Mon, 16 Mar 2009 15:16:08 +0100 [thread overview]
Message-ID: <1237212968.11067.3.camel@localhost.localdomain> (raw)
In-Reply-To: <1237197709.7210.2.camel@localhost.localdomain>
On Mon, 2009-03-16 at 11:01 +0100, Lubomir Rintel wrote:
> This should fix the following OOPS:
> http://www.kerneloops.org/raw.php?rawid=80591&msgid=
Wrong, sorry, the disassembly from kerneloops was a bit confusing to me.
Looking at the disassembly of the actual module:
> @@ -553,7 +553,8 @@ static int snd_opl3sa2_suspend(struct snd_card
> *card, pm_message_t state)
> struct snd_opl3sa2 *chip = card->private_data;
card must somehow be NULL here:
00000270 <snd_opl3sa2_suspend>:
270: 53 push %ebx
271: 8b 98 38 01 00 00 mov 0x138(%eax),%ebx
277: b9 01 00 00 00 mov $0x1,%ecx
27c: ba 03 00 00 00 mov $0x3,%edx
281: c7 80 a8 01 00 00 00 movl $0x300,0x1a8(%eax)
288: 03 00 00
28b: 05 bc 01 00 00 add $0x1bc,%eax
290: 6a 00 push $0x0
292: e8 fc ff ff ff call 293 <snd_opl3sa2_suspend+0x23>
297: 8b 53 24 mov 0x24(%ebx),%edx
29a: 89 d0 mov %edx,%eax
29c: ff 92 d4 00 00 00 call *0xd4(%edx)
2a2: 89 d8 mov %ebx,%eax
2a4: b9 27 00 00 00 mov $0x27,%ecx
2a9: ba 01 00 00 00 mov $0x1,%edx
2ae: e8 72 fe ff ff call 125 <snd_opl3sa2_write>
2b3: 58 pop %eax
2b4: 31 c0 xor %eax,%eax
2b6: 5b pop %ebx
2b7: c3 ret
This is the same issue, with 2.6.28:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=519939
next prev parent reply other threads:[~2009-03-16 14:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 10:01 [PATCH] Fix NULL dereference when suspending snd_opl3sa2 Lubomir Rintel
2009-03-16 10:01 ` Lubomir Rintel
2009-03-16 14:16 ` Lubomir Rintel [this message]
2009-03-16 14:16 ` Lubomir Rintel
2009-03-16 18:21 ` Krzysztof Helt
2009-03-16 18:21 ` Krzysztof Helt
2009-03-16 20:32 ` Krzysztof Helt
2009-03-16 20:32 ` Krzysztof Helt
2009-03-17 8:30 ` Takashi Iwai
2009-03-17 8:30 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237212968.11067.3.camel@localhost.localdomain \
--to=lkundrak@v3.sk \
--cc=akpm@linux-foundation.org \
--cc=krzysztof.h1@wp.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.