mlmmj: sends welcome E-mail when 'submod' is enabled

mlmmj: sends welcome E-mail when 'submod' is enabled

[Sebastian Harl]

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

Package: mlmmj
Version: 1.2.15-1.1
Severity: normal

Hi,

(Cc'ing the mlmmj mailinglist - a comment would be appreciated.)

When using mlmmj-sub without -c (i.e. subscription is supposed to happen
silently), mlmmj sends a welcome E-mail to the newly added user after
approving her when 'submod' is enabled. The user also gets a
notification that her subscription is waiting for approval by the
moderator.

Imho, it's not even desired that moderation should take place when
adding a user from the command line.

In any case, it would be nice if the user does not get any E-mails
unless -c is used.

TIA,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: mlmmj: sends welcome E-mail when 'submod' is enabled

[Morten K. Poulsen]

Hi Sebastian,

On Mon, 2009-03-16 at 10:21 +0100, Sebastian Harl wrote:
> Imho, it's not even desired that moderation should take place when
> adding a user from the command line.

I agree, but there should be a flag to enable moderation even if the
command line tool is used.

> In any case, it would be nice if the user does not get any E-mails
> unless -c is used.

Yes, although this is difficult (with the current design) if
subscription moderation is in use.

It would be great if you (or someone else) would write the code, and
send us a patch :)

Best regards,
Morten

-- 
Morten K. Poulsen <mopo@fabletech.com>
CTO, FableTech
http://fabletech.com/

Re: mlmmj: sends welcome E-mail when 'submod' is enabled

[Sebastian Harl]

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

Hi Morten,

On Mon, Mar 16, 2009 at 04:55:53PM +0100, Morten K. Poulsen wrote:
> On Mon, 2009-03-16 at 10:21 +0100, Sebastian Harl wrote:
> > Imho, it's not even desired that moderation should take place when
> > adding a user from the command line.
> 
> I agree, but there should be a flag to enable moderation even if the
> command line tool is used.

Yep - fully agreed. To not break backward-compatibility (if that's
desired), a flag could be added to _disable_ moderation while the
default behavior would still be to have moderation enabled.

> > In any case, it would be nice if the user does not get any E-mails
> > unless -c is used.
> 
> Yes, although this is difficult (with the current design) if
> subscription moderation is in use.

I have to admit that I did not yet look at the mlmmj internals at all,
but, I suppose, the current state of a subscription (before it has been
approved by the moderator) needs to be stored somewhere. So, possibly,
that place could be used to store additional flags as well.

> It would be great if you (or someone else) would write the code, and
> send us a patch :)

Sure. I might get to that later this week.

Thanks for the fast reply!

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]