From: Bartlomiej Zolnierkiewicz <b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Javier Martinez Canillas
<javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
Cc: Krzysztof Kozlowski
<krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings
Date: Wed, 31 Aug 2016 19:40:21 +0200 [thread overview]
Message-ID: <12377780.GCreFUiXAa@amdc1976> (raw)
In-Reply-To: <0da13ae1-90a8-912b-227e-0e94439953d5-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
Hi,
On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
> > On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
> >> Hello Krzysztof,
> >>
> >> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
> >> which allows to get rid of the DTC warnings about a mismatch between the
> >> memory nodes' unit names and reg properties.
> >>
> >> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
> >> but only the Exynos5 changes have been tested. The others patches were
> >> just built tested.
> >
> > I think this is a common problem, not only Exynos-specific, so I would
>
> That's correct.
>
> > prefer to stick to common pattern. Either all DTS/DTSI include skeleton
> > or none of them.
> >
>
> The idea is to get rid of skeleton.dtsi [0], but that will of course take
> time until the dtsi is removed from all the files. So this patch is a step
> in the right direction so at least Exynos is not a blocker to remove it.
Krzysztof's point is valid. If you are going to convert all DTS/DTSI
then it is okay to apply Exynos specific changes, otherwise the code
should stay as it is currently.
Exynos won't be a blocker since we have your patches now and they can
be applied when/if needed ;)..
> > Best regards,
> > Krzysztof
> >
>
> [0]: https://lkml.org/lkml/2016/8/3/195
>
> Best regards,
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Kukjin Kim <kgene@kernel.org>,
linux-samsung-soc@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings
Date: Wed, 31 Aug 2016 19:40:21 +0200 [thread overview]
Message-ID: <12377780.GCreFUiXAa@amdc1976> (raw)
In-Reply-To: <0da13ae1-90a8-912b-227e-0e94439953d5@osg.samsung.com>
Hi,
On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
> > On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
> >> Hello Krzysztof,
> >>
> >> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
> >> which allows to get rid of the DTC warnings about a mismatch between the
> >> memory nodes' unit names and reg properties.
> >>
> >> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
> >> but only the Exynos5 changes have been tested. The others patches were
> >> just built tested.
> >
> > I think this is a common problem, not only Exynos-specific, so I would
>
> That's correct.
>
> > prefer to stick to common pattern. Either all DTS/DTSI include skeleton
> > or none of them.
> >
>
> The idea is to get rid of skeleton.dtsi [0], but that will of course take
> time until the dtsi is removed from all the files. So this patch is a step
> in the right direction so at least Exynos is not a blocker to remove it.
Krzysztof's point is valid. If you are going to convert all DTS/DTSI
then it is okay to apply Exynos specific changes, otherwise the code
should stay as it is currently.
Exynos won't be a blocker since we have your patches now and they can
be applied when/if needed ;)..
> > Best regards,
> > Krzysztof
> >
>
> [0]: https://lkml.org/lkml/2016/8/3/195
>
> Best regards,
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2016-08-31 17:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 12:14 [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Javier Martinez Canillas
2016-08-31 12:14 ` [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards Javier Martinez Canillas
2016-08-31 17:22 ` Bartlomiej Zolnierkiewicz
2016-09-01 8:30 ` Javier Martinez Canillas
2016-09-01 8:30 ` Javier Martinez Canillas
2016-08-31 17:46 ` Krzysztof Kozlowski
2016-09-01 8:43 ` Javier Martinez Canillas
2016-09-01 9:05 ` Krzysztof Kozlowski
[not found] ` <e3cdab3d-f1ef-f751-b169-e3328178b835-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-09-01 9:19 ` Javier Martinez Canillas
2016-09-01 9:19 ` Javier Martinez Canillas
[not found] ` <0e8e0b3c-0dd9-c44b-d1ad-03c840d3a725-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-09-01 9:28 ` Krzysztof Kozlowski
2016-09-01 9:28 ` Krzysztof Kozlowski
2016-09-01 9:36 ` Javier Martinez Canillas
[not found] ` <184ad5f6-5528-2ad7-7c2b-46beda9b6dc9-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-09-01 9:48 ` Krzysztof Kozlowski
2016-09-01 9:48 ` Krzysztof Kozlowski
2016-08-31 12:14 ` [PATCH 2/7] ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos3 Javier Martinez Canillas
2016-08-31 12:14 ` [PATCH 3/7] ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos4 Javier Martinez Canillas
2016-08-31 12:14 ` [PATCH 4/7] ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos5 Javier Martinez Canillas
2016-08-31 12:14 ` [PATCH 5/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos3 DTS Javier Martinez Canillas
2016-08-31 12:14 ` [PATCH 7/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos5 DTS Javier Martinez Canillas
[not found] ` <1472645679-5696-1-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-08-31 12:14 ` [PATCH 6/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos4 DTS Javier Martinez Canillas
2016-08-31 12:14 ` Javier Martinez Canillas
2016-08-31 12:55 ` [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Krzysztof Kozlowski
2016-08-31 12:55 ` Krzysztof Kozlowski
[not found] ` <5366f8a4-b4fb-ec2d-eb1e-5534f24c4a07-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-08-31 13:45 ` Javier Martinez Canillas
2016-08-31 13:45 ` Javier Martinez Canillas
[not found] ` <0da13ae1-90a8-912b-227e-0e94439953d5-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-08-31 17:40 ` Bartlomiej Zolnierkiewicz [this message]
2016-08-31 17:40 ` Bartlomiej Zolnierkiewicz
2016-09-01 8:35 ` Javier Martinez Canillas
2016-09-01 8:35 ` Javier Martinez Canillas
2016-09-01 9:59 ` Bartlomiej Zolnierkiewicz
2016-09-01 11:40 ` Mark Rutland
2016-09-01 11:59 ` Bartlomiej Zolnierkiewicz
2016-08-31 17:47 ` Krzysztof Kozlowski
2016-08-31 17:47 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12377780.GCreFUiXAa@amdc1976 \
--to=b.zolnierkie-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
--cc=kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.