Re: [Qemu-devel] [RFC] Introduce module API to QEMU

[Mark McLoughlin <markmc@redhat.com>]

Hey,

Generally looks good to me.

On Thu, 2009-04-02 at 21:12 -0500, Anthony Liguori wrote:
> diff --git a/hw/mcf_fec.c b/hw/mcf_fec.c
> index 413c569..49ae69b 100644
> --- a/hw/mcf_fec.c
> +++ b/hw/mcf_fec.c
> @@ -446,8 +446,6 @@ void mcf_fec_init(NICInfo *nd, target_phys_addr_t base, qemu_irq *irq)
>      mcf_fec_state *s;
>      int iomemtype;
>  
> -    qemu_check_nic_model(nd, "mcf_fec");

It's obscure, but this line does three things:

  1) Makes 'qemu-system-m68k -net nic,model=?' list the available model

  2) Makes 'qemu-system-m68k -net nic,model=e1000' fail

  3) Makes 'qemu-system-m68k -net nic' have sane 'info network' output 
     - i.e. the model is listed as mcf_fec

That goes for the other non-PCI NICs too.

Cheers,
Mark.