All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [RFC] Introduce module API to QEMU
Date: Fri, 03 Apr 2009 17:53:38 +0300	[thread overview]
Message-ID: <49D622F2.705@redhat.com> (raw)
In-Reply-To: <49D61924.3080803@codemonkey.ws>

Anthony Liguori wrote:
>>
>> Hmm, this raises annother issue - we've got to be extremely careful 
>> about ordering. It's not inconcievable that the PCI support code 
>> would have constructors (e.g. to register a PCI bus type).
>>   
>
> Looks like constructor/destructor has explicit support for ordering.  
> Neat.

I'd avoid it.  Have the constructor do a *pci_module_table++ = blah and 
iterate through that later.

I prefer to have the code explicit somewhere rather than gobs of 
unportable magic.  Use it where you have to, but not elsewhere.


-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

  parent reply	other threads:[~2009-04-03 14:55 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-03  2:12 [Qemu-devel] [RFC] Introduce module API to QEMU Anthony Liguori
2009-04-03  2:29 ` malc
2009-04-03  3:36   ` Anthony Liguori
2009-04-03  3:48     ` malc
2009-04-03 12:59       ` Anthony Liguori
2009-04-03 17:00         ` malc
2009-04-03 17:31           ` Anthony Liguori
2009-04-03 17:46             ` malc
2009-04-03 17:59               ` M. Warner Losh
2009-04-03 17:58             ` M. Warner Losh
2009-04-03 18:05               ` Anthony Liguori
2009-04-03 20:12               ` Kevin Wolf
2009-04-03 18:30                 ` malc
2009-04-03  7:08 ` Mark McLoughlin
2009-04-03 13:01   ` Anthony Liguori
2009-04-03 17:36   ` Anthony Liguori
2009-04-03  7:50 ` Avi Kivity
2009-04-03 11:35 ` Paul Brook
2009-04-03 12:57   ` Anthony Liguori
2009-04-03 13:09     ` Paul Brook
2009-04-03 14:10       ` Anthony Liguori
2009-04-03 14:11       ` Anthony Liguori
2009-04-03 14:28         ` Paul Brook
2009-04-03 14:53         ` Avi Kivity [this message]
2009-04-03 16:15           ` Anthony Liguori
2009-04-03 17:12     ` Blue Swirl
2009-04-03 14:04 ` Daniel Jacobowitz
2009-04-03 14:54   ` Avi Kivity
2009-04-03 15:10     ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D622F2.705@redhat.com \
    --to=avi@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.