Kernel freeze caused by a7bb3909b3293d503211d7f6af8ed62c1644b686

Kernel freeze caused by a7bb3909b3293d503211d7f6af8ed62c1644b686

[Daniel Ribeiro]

Hi Eric!

Today i was updating my code from linus git, and all my devices freeze
with a white screen of death at early boot.

I bisected it, and found that commit 
a7bb3909b3293d503211d7f6af8ed62c1644b686 is the culprit.

My code still uses cs_control to toggle the CS gpio. Is your commit
supposed to deprecate cs_control?

-- 
Daniel Ribeiro


------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com

Re: Kernel freeze caused by a7bb3909b3293d503211d7f6af8ed62c1644b686

[Eric Miao]

On Thu, Apr 9, 2009 at 2:28 AM, Daniel Ribeiro <drwyrm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hi Eric!
>
> Today i was updating my code from linus git, and all my devices freeze
> with a white screen of death at early boot.
>
> I bisected it, and found that commit
> a7bb3909b3293d503211d7f6af8ed62c1644b686 is the culprit.
>
> My code still uses cs_control to toggle the CS gpio. Is your commit
> supposed to deprecate cs_control?
>

No, should be backward compatible and I verified it before submitting
the patch. Could you please help identify why it fails and I'm going to
reproduce it here as well.

------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com

Re: Kernel freeze caused by a7bb3909b3293d503211d7f6af8ed62c1644b686

[Daniel Ribeiro]

Em Qui, 2009-04-09 às 08:41 +0800, Eric Miao escreveu:
> > I bisected it, and found that commit
> > a7bb3909b3293d503211d7f6af8ed62c1644b686 is the culprit.
> >
> > My code still uses cs_control to toggle the CS gpio. Is your commit
> > supposed to deprecate cs_control?
> >
> 
> No, should be backward compatible and I verified it before submitting
> the patch. Could you please help identify why it fails and I'm going to
> reproduce it here as well.

Fix is trivial, sorry for not seeing this earlier. I have no idea why my
device freezes at startup, but this is enough to get everything working
again.


Correct typo on pxa2xx-spi.c cs_deassert.

Signed-off-by: Daniel Ribeiro <drwyrm@gmail.com>

diff --git a/drivers/spi/pxa2xx_spi.c b/drivers/spi/pxa2xx_spi.c
index 79d7341..1a00b41 100644
--- a/drivers/spi/pxa2xx_spi.c
+++ b/drivers/spi/pxa2xx_spi.c
@@ -195,7 +195,7 @@ static void cs_deassert(struct driver_data *drv_data)
 	struct chip_data *chip = drv_data->cur_chip;
 
 	if (chip->cs_control) {
-		chip->cs_control(PXA2XX_CS_ASSERT);
+		chip->cs_control(PXA2XX_CS_DEASSERT);
 		return;
 	}
 

-- 
Daniel Ribeiro


------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Re: Kernel freeze caused by a7bb3909b3293d503211d7f6af8ed62c1644b686

[Eric Miao]

On Thu, Apr 9, 2009 at 9:48 AM, Daniel Ribeiro <drwyrm@gmail.com> wrote:
> Em Qui, 2009-04-09 às 08:41 +0800, Eric Miao escreveu:
>> > I bisected it, and found that commit
>> > a7bb3909b3293d503211d7f6af8ed62c1644b686 is the culprit.
>> >
>> > My code still uses cs_control to toggle the CS gpio. Is your commit
>> > supposed to deprecate cs_control?
>> >
>>
>> No, should be backward compatible and I verified it before submitting
>> the patch. Could you please help identify why it fails and I'm going to
>> reproduce it here as well.
>
> Fix is trivial, sorry for not seeing this earlier. I have no idea why my
> device freezes at startup, but this is enough to get everything working
> again.
>
>
> Correct typo on pxa2xx-spi.c cs_deassert.
>

Grrr.... this is really embarassing, shame me ///

> Signed-off-by: Daniel Ribeiro <drwyrm@gmail.com>
>

Acked-by: Eric Miao <eric.miao@marvell.com>

David,

Please help merge this patch, thanks.

------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general