Re: [Qemu-devel] [PATCH 1/7] net: Fix -net socket,listen

[Mark McLoughlin <markmc@redhat.com>]

On Tue, 2009-04-14 at 19:29 +0200, Jan Kiszka wrote:
> In case no symbolic name is provided when requesting VLAN connection via
> listening TCP socket ('-net socket,listen=...'), qemu crashes. This
> fixes the cause.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
>  net.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net.c b/net.c
> index 5365891..c7e4a0b 100644
> --- a/net.c
> +++ b/net.c
> @@ -1440,7 +1440,7 @@ static int net_socket_listen_init(VLANState *vlan,
>      }
>      s->vlan = vlan;
>      s->model = strdup(model);
> -    s->name = strdup(name);
> +    s->name = name ? strdup(name) : NULL;

Yep, this is a slightly unusual case because we're not allocating a
VLANClientState here which would cause a default name to be assigned.

Acked-by: Mark McLoughlin <markmc@redhat.com>

Cheers,
Mark.