[Qemu-devel] Re: [PATCH 3/7] net: Check device passed to host_net_remove

[Jan Kiszka <jan.kiszka@siemens.com>]

Mark McLoughlin wrote:
> On Tue, 2009-04-14 at 19:29 +0200, Jan Kiszka wrote:
>> Make sure that we do not delete guest NICs via host_net_remove.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>>  net.c |   11 +++++++++--
>>  1 files changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/net.c b/net.c
>> index 36c0509..787f249 100644
>> --- a/net.c
>> +++ b/net.c
>> @@ -1861,9 +1861,16 @@ void net_host_device_remove(Monitor *mon, int vlan_id, const char *device)
>>          return;
>>      }
>>  
>> -   for(vc = vlan->first_client; vc != NULL; vc = vc->next)
>> -        if (!strcmp(vc->name, device))
>> +    if (!net_host_check_device(device)) {
>> +        monitor_printf(mon, "invalid host network device %s\n", device);
>> +        return;
>> +    }
> 
> Doesn't this mean that if you assign a name with e.g. "name=foo1234" you
> won't be able to remove it?

Good point.

> 
> Probably makes more sense to find the client, then check vc->model using
> net_host_check_device()?

Yes, will fix.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux