From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kalle.valo@iki.fi>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 0/3] mac80211 powersave improvements
Date: Thu, 16 Apr 2009 13:06:40 +0200 [thread overview]
Message-ID: <1239880000.9737.20.camel@johannes.local> (raw)
In-Reply-To: <87iql4981b.fsf@litku.valot.fi> (sfid-20090416_130208_558130_BEE7A112)
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
On Thu, 2009-04-16 at 14:01 +0300, Kalle Valo wrote:
> > 1) improve powersave to only allow it when a single
> > managed interface is active
> >
> > 2) disable PS when the maximum networking latency
> > applications are are willing to put up with is
> > smaller than the beacon interval -- in that case
> > we cannot allow the AP to buffer frames
>
> No problem with these.
I'll send these along with the software beacon filtering, I think.
> > 3) enable powersave by default
> >
> > The last part might be controversial?
>
> I think this a bad idea. For normal users we should not enable powersave
> by default, at least not yet. I believe that there would be so much
> problems that we would have to revert the change eventually.
We can go with the configurable one -- and default y in wireless-testing
but default n in mainline for a while. Get press coverage etc. and at
some point flip the switch.
> > Should we have a default setting for the dynamic PS
> > timeout?
>
> Yes. Having timeout zero makes no sense in normal laptop use.
So, what's a good default? Fairly long I'd say, maybe 500ms?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-04-16 11:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 17:10 [RFC 0/3] mac80211 powersave improvements Johannes Berg
2009-04-15 17:10 ` [RFC 1/3] mac80211: improve powersave implementation Johannes Berg
2009-04-15 19:38 ` [RFC 1/3 v2] " Johannes Berg
2009-04-16 10:55 ` Kalle Valo
2009-04-15 17:10 ` [RFC 2/3] mac80211: disable powersave if pm_qos asks for low latency Johannes Berg
2009-04-15 19:38 ` [RFC 2/3 v2] " Johannes Berg
2009-04-16 10:58 ` Kalle Valo
2009-04-15 17:10 ` [RFC 3/3] mac80211: enable PS by default Johannes Berg
2009-04-16 10:39 ` [RFC 3/3 v2] " Johannes Berg
2009-04-16 11:01 ` [RFC 0/3] mac80211 powersave improvements Kalle Valo
2009-04-16 11:06 ` Johannes Berg [this message]
2009-04-16 11:11 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239880000.9737.20.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.