Re: [RFC 0/3] mac80211 powersave improvements

[Kalle Valo <kalle.valo@iki.fi>]

Johannes Berg <johannes@sipsolutions.net> writes:

> Hi,

Hallo,

> This series contains the following:
>
>  1) improve powersave to only allow it when a single
>     managed interface is active
>
>  2) disable PS when the maximum networking latency
>     applications are are willing to put up with is
>     smaller than the beacon interval -- in that case
>     we cannot allow the AP to buffer frames

No problem with these.

>  3) enable powersave by default
>
> The last part might be controversial?

I think this a bad idea. For normal users we should not enable powersave
by default, at least not yet. I believe that there would be so much
problems that we would have to revert the change eventually.

> Should we have a default setting for the dynamic PS
> timeout?

Yes. Having timeout zero makes no sense in normal laptop use.

> Oh also -- below is a small program to play with the
> pm_qos framework, feel free to rip it for anything.

Thanks, this is useful.

-- 
Kalle Valo