From: Chris Mason <chris.mason@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: implement FS_IOC_GETFLAGS/SETFLAGS/GETVERSION
Date: Thu, 23 Apr 2009 15:56:21 -0400 [thread overview]
Message-ID: <1240516581.28015.21.camel@think.oraclecorp.com> (raw)
In-Reply-To: <20090417083741.GA14933@lst.de>
On Fri, 2009-04-17 at 10:37 +0200, Christoph Hellwig wrote:
> Add support for the standard attributes set via chattr and read vis
> lsattr. Currently we store the attributes in the flags value in
> the btrfs inode, but I wonder whether we should split it into two so
> that we don't have to keep converting between the two formats.
>
> Remove the btrfs_clear_flag/btrfs_set_flag/btrfs_test_flag macros
> as they were obsfuction the existing code and got in the way of the
> new additions.
>
> Also add the FS_IOC_GETVERSION ioctl for getting i_generation as it's
> trivial.
>
Thanks.
> Btw, any idea what the BTRFS_INODE_REDONLY flag is for? It's a subset
> of the immutable flag, but can't actually be set anywhere from the
> filesystem code.
>
The ext3 converter sets BTRFS_INODE_READONLY on the ext3 image file.
-chris
next prev parent reply other threads:[~2009-04-23 19:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 8:37 [PATCH] btrfs: implement FS_IOC_GETFLAGS/SETFLAGS/GETVERSION Christoph Hellwig
2009-04-17 10:11 ` Edward Shishkin
2009-04-20 15:47 ` Christoph Hellwig
2009-04-21 21:30 ` Edward Shishkin
2009-04-23 14:00 ` Chris Ball
2009-04-23 18:01 ` Christoph Hellwig
2009-04-23 19:56 ` Chris Mason [this message]
2009-04-25 19:13 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240516581.28015.21.camel@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.