From: Christoph Hellwig <hch@lst.de>
To: Chris Ball <cjb@laptop.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: implement FS_IOC_GETFLAGS/SETFLAGS/GETVERSION
Date: Thu, 23 Apr 2009 20:01:31 +0200 [thread overview]
Message-ID: <20090423180131.GA17835@lst.de> (raw)
In-Reply-To: <m3vdovo4fc.fsf@pullcord.laptop.org>
On Thu, Apr 23, 2009 at 10:00:55AM -0400, Chris Ball wrote:
> Hi Christoph,
>
> > Add support for the standard attributes set via chattr and read
> > vis lsattr. Currently we store the attributes in the flags value
> > in the btrfs inode, but I wonder whether we should split it into
> > two so that we don't have to keep converting between the two
> > formats.
>
> Any thoughts on how best to add support for setting the custom btrfs
> flags (nodatasum/nodatacow/nocompress) via an ioctl? Is it possible
> to reuse FS_IOC_SETFLAGS for these too, or do we need a new ioctl?
> If we need a new one, any preference between an ioctl per flag vs.
> a single ioctl that accepts a new set of flags?
I think adding them here is a good idea. In fact nocompress already
has a flag assigned, I just didn't want to put it in without broader
consultation first as it's not used yet in any mainline code.
next prev parent reply other threads:[~2009-04-23 18:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 8:37 [PATCH] btrfs: implement FS_IOC_GETFLAGS/SETFLAGS/GETVERSION Christoph Hellwig
2009-04-17 10:11 ` Edward Shishkin
2009-04-20 15:47 ` Christoph Hellwig
2009-04-21 21:30 ` Edward Shishkin
2009-04-23 14:00 ` Chris Ball
2009-04-23 18:01 ` Christoph Hellwig [this message]
2009-04-23 19:56 ` Chris Mason
2009-04-25 19:13 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090423180131.GA17835@lst.de \
--to=hch@lst.de \
--cc=cjb@laptop.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.