From: Mark Drago <markdrago@gmail.com>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Mark Drago <markdrago@gmail.com>
Subject: [PATCH] Add semicolon to curly brace group in main Makefile
Date: Sun, 26 Apr 2009 22:36:48 -0400 [thread overview]
Message-ID: <1240799808-7340-1-git-send-email-markdrago@gmail.com> (raw)
This semicolon is technically required by bash and indeed caused a syntax error
on a system that I came across running, an admittedly very old, bash-2.04.0.
http://www.gnu.org/software/bash/manual/bashref.html#Command-Grouping
Signed-off-by: Mark Drago <markdrago@gmail.com>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 5c8e83a..f006d2c 100644
--- a/Makefile
+++ b/Makefile
@@ -1557,7 +1557,7 @@ endif
ln "$$execdir/git-add$X" "$$execdir/$$p" 2>/dev/null || \
ln -s "git-add$X" "$$execdir/$$p" 2>/dev/null || \
cp "$$execdir/git-add$X" "$$execdir/$$p" || exit; \
- done } && \
+ done; } && \
./check_bindir "z$$bindir" "z$$execdir" "$$bindir/git-add$X"
install-doc:
--
1.5.6.3
next reply other threads:[~2009-04-27 2:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 2:36 Mark Drago [this message]
2009-04-27 6:21 ` [PATCH] Add semicolon to curly brace group in main Makefile Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240799808-7340-1-git-send-email-markdrago@gmail.com \
--to=markdrago@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.