All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Mark Drago <markdrago@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Add semicolon to curly brace group in main Makefile
Date: Sun, 26 Apr 2009 23:21:44 -0700	[thread overview]
Message-ID: <7vhc0aaa6f.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1240799808-7340-1-git-send-email-markdrago@gmail.com> (Mark Drago's message of "Sun, 26 Apr 2009 22:36:48 -0400")

Mark Drago <markdrago@gmail.com> writes:

> This semicolon is technically required by bash and indeed caused a syntax error
> on a system that I came across running, an admittedly very old, bash-2.04.0.
>
> http://www.gnu.org/software/bash/manual/bashref.html#Command-Grouping
>
> Signed-off-by: Mark Drago <markdrago@gmail.com>

Thanks; it is not specific to bash.  At the end of compound_list before
the Rbrace at the end of brace_group, a separator is required.

      reply	other threads:[~2009-04-27  6:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27  2:36 [PATCH] Add semicolon to curly brace group in main Makefile Mark Drago
2009-04-27  6:21 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vhc0aaa6f.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=markdrago@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.