Re: [PATCH 1/2] Add support for Designware SATA controller driver

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Wed, 2009-04-29 at 14:42 -0700, Feng Kan wrote:
> Signed-off-by: Feng Kan <fkan@amcc.com>
> ---
>  drivers/ata/Kconfig    |   76 +-
>  drivers/ata/Makefile   |    1 +
>  drivers/ata/sata_dwc.c | 2047 ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 2091 insertions(+), 33 deletions(-)
>  create mode 100644 drivers/ata/sata_dwc.c
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 0bcf264..5321e47 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -72,56 +72,66 @@ config SATA_FSL
>  
>  	  If unsure, say N.
>  
> -config ATA_SFF
> -	bool "ATA SFF support"
> -	default y

Hi Feng !

Nice to see this driver finally submitted !

However, it should be sent to the linux-ide mailing list in order to be
reviewed by the right people (though you should keep linuxppc-dev on
CC).

Also, I think you want to avoid that Kconfig churn, just add your option
as a drop-in, don't re-arrange half of the file while at it :-)

Cheers,
Ben.