From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: Feng Kan <fkan@amcc.com>,
linuxppc-dev@ozlabs.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] Add support for Designware SATA controller driver
Date: Fri, 01 May 2009 18:49:08 +1000 [thread overview]
Message-ID: <1241167748.1781.3.camel@pasglop> (raw)
In-Reply-To: <49FAA434.9040106@garzik.org>
On Fri, 2009-05-01 at 03:26 -0400, Jeff Garzik wrote:
> Feng Kan wrote:
> > Signed-off-by: Feng Kan <fkan@amcc.com>
> > ---
> > drivers/ata/Kconfig | 76 +-
> > drivers/ata/Makefile | 1 +
> > drivers/ata/sata_dwc.c | 2047 ++++++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 2091 insertions(+), 33 deletions(-)
> > create mode 100644 drivers/ata/sata_dwc.c
>
> I don't see a patch 2/2 ?
Patch 2/2 is just adding the device-tree bits to the platform for
this driver to match against, so it's no big deal. However, Feng,
we already mentioned that you do a lot of unrelated changes to the
Kconfig file that shouldn't be part of this patch, just add the
entry for this chip, don't move stuff around in Kconfig, unless I
missed a good reason why this is done that way.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: linuxppc-dev@ozlabs.org, Feng Kan <fkan@amcc.com>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] Add support for Designware SATA controller driver
Date: Fri, 01 May 2009 18:49:08 +1000 [thread overview]
Message-ID: <1241167748.1781.3.camel@pasglop> (raw)
In-Reply-To: <49FAA434.9040106@garzik.org>
On Fri, 2009-05-01 at 03:26 -0400, Jeff Garzik wrote:
> Feng Kan wrote:
> > Signed-off-by: Feng Kan <fkan@amcc.com>
> > ---
> > drivers/ata/Kconfig | 76 +-
> > drivers/ata/Makefile | 1 +
> > drivers/ata/sata_dwc.c | 2047 ++++++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 2091 insertions(+), 33 deletions(-)
> > create mode 100644 drivers/ata/sata_dwc.c
>
> I don't see a patch 2/2 ?
Patch 2/2 is just adding the device-tree bits to the platform for
this driver to match against, so it's no big deal. However, Feng,
we already mentioned that you do a lot of unrelated changes to the
Kconfig file that shouldn't be part of this patch, just add the
entry for this chip, don't move stuff around in Kconfig, unless I
missed a good reason why this is done that way.
Cheers,
Ben.
next prev parent reply other threads:[~2009-05-01 8:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 22:00 [PATCH 1/2] Add support for Designware SATA controller driver Feng Kan
2009-04-29 23:28 ` Wolfgang Denk
2009-04-29 23:35 ` Mark Miesfeld
2009-04-29 23:35 ` Mark Miesfeld
2009-05-01 7:26 ` Jeff Garzik
2009-05-01 8:49 ` Benjamin Herrenschmidt [this message]
2009-05-01 8:49 ` Benjamin Herrenschmidt
2009-05-01 14:07 ` Jeff Garzik
2009-05-01 14:07 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2009-04-29 21:42 Feng Kan
2009-04-29 21:47 ` Kumar Gala
2009-04-30 4:30 ` Stephen Rothwell
2009-04-30 6:05 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241167748.1781.3.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=fkan@amcc.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.