From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: linuxppc-dev@ozlabs.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] 2.6.30-rc3: BUG triggered on some hugepage usages
Date: Fri, 01 May 2009 07:48:46 +1000 [thread overview]
Message-ID: <1241128126.29501.48.camel@pasglop> (raw)
In-Reply-To: <20090430205919.GA24279@csn.ul.ie>
On Thu, 2009-04-30 at 21:59 +0100, Mel Gorman wrote:
> This patch fixes the problem by not asseting the PTE is locked for VMAs
> backed by huge pages.
Thanks, will apply.
Cheers,
Ben.
> Signed-off-by: Mel Gorman <mel@csn.ul.ie>
> ---
> arch/powerpc/mm/pgtable.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c
> index f5c6fd4..ae1d67c 100644
> --- a/arch/powerpc/mm/pgtable.c
> +++ b/arch/powerpc/mm/pgtable.c
> @@ -219,7 +219,8 @@ int ptep_set_access_flags(struct vm_area_struct *vma, unsigned long address,
> entry = do_dcache_icache_coherency(entry);
> changed = !pte_same(*(ptep), entry);
> if (changed) {
> - assert_pte_locked(vma->vm_mm, address);
> + if (!(vma->vm_flags & VM_HUGETLB))
> + assert_pte_locked(vma->vm_mm, address);
> __ptep_set_access_flags(ptep, entry);
> flush_tlb_page_nohash(vma, address);
> }
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Michael Ellerman <michael@ellerman.id.au>,
Linus Torvalds <torvalds@linux-foundation.org>,
linuxppc-dev@ozlabs.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] 2.6.30-rc3: BUG triggered on some hugepage usages
Date: Fri, 01 May 2009 07:48:46 +1000 [thread overview]
Message-ID: <1241128126.29501.48.camel@pasglop> (raw)
In-Reply-To: <20090430205919.GA24279@csn.ul.ie>
On Thu, 2009-04-30 at 21:59 +0100, Mel Gorman wrote:
> This patch fixes the problem by not asseting the PTE is locked for VMAs
> backed by huge pages.
Thanks, will apply.
Cheers,
Ben.
> Signed-off-by: Mel Gorman <mel@csn.ul.ie>
> ---
> arch/powerpc/mm/pgtable.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c
> index f5c6fd4..ae1d67c 100644
> --- a/arch/powerpc/mm/pgtable.c
> +++ b/arch/powerpc/mm/pgtable.c
> @@ -219,7 +219,8 @@ int ptep_set_access_flags(struct vm_area_struct *vma, unsigned long address,
> entry = do_dcache_icache_coherency(entry);
> changed = !pte_same(*(ptep), entry);
> if (changed) {
> - assert_pte_locked(vma->vm_mm, address);
> + if (!(vma->vm_flags & VM_HUGETLB))
> + assert_pte_locked(vma->vm_mm, address);
> __ptep_set_access_flags(ptep, entry);
> flush_tlb_page_nohash(vma, address);
> }
next prev parent reply other threads:[~2009-04-30 21:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 3:27 Linus 2.6.30-rc3 Linus Torvalds
2009-04-22 6:20 ` Ingo Molnar
2009-04-22 6:38 ` [PATCH] include/linux/pktcdvd.h: add mempool.h dependency Ingo Molnar
2009-04-22 6:39 ` Jens Axboe
2009-04-22 6:54 ` Ingo Molnar
2009-04-22 6:58 ` Jens Axboe
2009-04-22 7:06 ` Ingo Molnar
2009-04-22 6:42 ` Ingo Molnar
2009-04-22 9:24 ` Linus 2.6.30-rc3 Denys Vlasenko
2009-04-24 9:51 ` [BUG] 2.6.30-rc3: BUG triggered on some hugepage usages Mel Gorman
2009-04-24 9:51 ` Mel Gorman
2009-04-24 15:24 ` Michael Ellerman
2009-04-24 15:24 ` Michael Ellerman
2009-04-30 20:59 ` Mel Gorman
2009-04-30 20:59 ` Mel Gorman
2009-04-30 21:48 ` Benjamin Herrenschmidt [this message]
2009-04-30 21:48 ` Benjamin Herrenschmidt
2009-05-18 17:13 ` Mel Gorman
2009-05-18 17:13 ` Mel Gorman
2009-05-18 17:26 ` Linus Torvalds
2009-05-18 17:26 ` Linus Torvalds
2009-04-27 8:15 ` Benjamin Herrenschmidt
2009-04-27 8:15 ` Benjamin Herrenschmidt
2009-04-24 17:52 ` [BUG] 2.6.30-rc3: bnx2 failing to load firmware Mel Gorman
2009-04-24 18:31 ` Frans Pop
2009-04-24 18:37 ` Linus Torvalds
2009-04-24 19:02 ` Frans Pop
2009-04-27 12:34 ` Martin Knoblauch
2009-04-27 13:33 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241128126.29501.48.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mel@csn.ul.ie \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.