From: Michael Ellerman <michael@ellerman.id.au>
To: Tim Abbott <tabbott@MIT.EDU>
Cc: Denys Vlasenko <vda.linux@googlemail.com>,
Jeff Arnold <jbarnold@MIT.EDU>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Anders Kaseorg <andersk@MIT.EDU>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Sam Ravnborg <sam@ravnborg.org>, Waseem Daher <wdaher@MIT.EDU>
Subject: Re: [PATCH 2/8] powerpc: share .data output section definition between 32 and 64 bits.
Date: Fri, 01 May 2009 11:46:42 +1000 [thread overview]
Message-ID: <1241142402.6928.7.camel@concordia> (raw)
In-Reply-To: <1241135777-9462-3-git-send-email-tabbott@mit.edu>
[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]
On Thu, 2009-04-30 at 19:56 -0400, Tim Abbott wrote:
> Since upcoming changes will add several more common pieces of code
> between the 32-bit and 64-bit powerpc architectures, it seems best to
> unify these two blocks.
>
> Signed-off-by: Tim Abbott <tabbott@mit.edu>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: linuxppc-dev@ozlabs.org
> ---
> arch/powerpc/kernel/vmlinux.lds.S | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/kernel/vmlinux.lds.S b/arch/powerpc/kernel/vmlinux.lds.S
> index a047a6c..47899b0 100644
> --- a/arch/powerpc/kernel/vmlinux.lds.S
> +++ b/arch/powerpc/kernel/vmlinux.lds.S
> @@ -220,20 +220,19 @@ SECTIONS
> . = ALIGN(PAGE_SIZE);
> _sdata = .;
>
> -#ifdef CONFIG_PPC32
> .data : AT(ADDR(.data) - LOAD_OFFSET) {
> DATA_DATA
> +#ifdef CONFIG_PPC32
> *(.sdata)
> *(.got.plt) *(.got)
> - }
> #else
> - .data : AT(ADDR(.data) - LOAD_OFFSET) {
> - DATA_DATA
> *(.data.rel*)
> *(.toc1)
> *(.branch_lt)
> +#endif
> }
>
> +#ifndef CONFIG_PPC32
> .opd : AT(ADDR(.opd) - LOAD_OFFSET) {
> *(.opd)
> }
This would be clearer in the positive, as in #ifdef CONFIG_PPC64.
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <michael@ellerman.id.au>
To: Tim Abbott <tabbott@MIT.EDU>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Denys Vlasenko <vda.linux@googlemail.com>,
Jeff Arnold <jbarnold@MIT.EDU>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Anders Kaseorg <andersk@MIT.EDU>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Waseem Daher <wdaher@MIT.EDU>
Subject: Re: [PATCH 2/8] powerpc: share .data output section definition between 32 and 64 bits.
Date: Fri, 01 May 2009 11:46:42 +1000 [thread overview]
Message-ID: <1241142402.6928.7.camel@concordia> (raw)
In-Reply-To: <1241135777-9462-3-git-send-email-tabbott@mit.edu>
[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]
On Thu, 2009-04-30 at 19:56 -0400, Tim Abbott wrote:
> Since upcoming changes will add several more common pieces of code
> between the 32-bit and 64-bit powerpc architectures, it seems best to
> unify these two blocks.
>
> Signed-off-by: Tim Abbott <tabbott@mit.edu>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: linuxppc-dev@ozlabs.org
> ---
> arch/powerpc/kernel/vmlinux.lds.S | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/kernel/vmlinux.lds.S b/arch/powerpc/kernel/vmlinux.lds.S
> index a047a6c..47899b0 100644
> --- a/arch/powerpc/kernel/vmlinux.lds.S
> +++ b/arch/powerpc/kernel/vmlinux.lds.S
> @@ -220,20 +220,19 @@ SECTIONS
> . = ALIGN(PAGE_SIZE);
> _sdata = .;
>
> -#ifdef CONFIG_PPC32
> .data : AT(ADDR(.data) - LOAD_OFFSET) {
> DATA_DATA
> +#ifdef CONFIG_PPC32
> *(.sdata)
> *(.got.plt) *(.got)
> - }
> #else
> - .data : AT(ADDR(.data) - LOAD_OFFSET) {
> - DATA_DATA
> *(.data.rel*)
> *(.toc1)
> *(.branch_lt)
> +#endif
> }
>
> +#ifndef CONFIG_PPC32
> .opd : AT(ADDR(.opd) - LOAD_OFFSET) {
> *(.opd)
> }
This would be clearer in the positive, as in #ifdef CONFIG_PPC64.
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-05-01 1:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 23:56 [PATCH 0/8] section name cleanup for powerpc Tim Abbott
2009-04-30 23:56 ` Tim Abbott
2009-04-30 23:56 ` [PATCH 1/8] powerpc: Remove unused __page_aligned macro Tim Abbott
2009-04-30 23:56 ` Tim Abbott
2009-04-30 23:56 ` [PATCH 2/8] powerpc: share .data output section definition between 32 and 64 bits Tim Abbott
2009-04-30 23:56 ` Tim Abbott
2009-04-30 23:56 ` [PATCH 3/8] powerpc: Use macros for .data.page_aligned section Tim Abbott
2009-04-30 23:56 ` Tim Abbott
2009-04-30 23:56 ` [PATCH 4/8] powerpc: use NOSAVE_DATA macro for .data.nosave section Tim Abbott
2009-04-30 23:56 ` Tim Abbott
2009-04-30 23:56 ` [PATCH 5/8] powerpc: use new macro for .data.cacheline_aligned section Tim Abbott
2009-04-30 23:56 ` Tim Abbott
2009-04-30 23:56 ` [PATCH 6/8] powerpc: use new macros for .data.init_task Tim Abbott
2009-04-30 23:56 ` Tim Abbott
2009-04-30 23:56 ` [PATCH 7/8] powerpc: use new macro for .data.read_mostly section Tim Abbott
2009-04-30 23:56 ` Tim Abbott
2009-04-30 23:56 ` [PATCH 8/8] powerpc: convert to new generic read_mostly support Tim Abbott
2009-04-30 23:56 ` Tim Abbott
2009-05-18 4:23 ` [PATCH 5/8] powerpc: use new macro for .data.cacheline_aligned section Benjamin Herrenschmidt
2009-05-18 4:23 ` Benjamin Herrenschmidt
2009-05-01 1:46 ` Michael Ellerman [this message]
2009-05-01 1:46 ` [PATCH 2/8] powerpc: share .data output section definition between 32 and 64 bits Michael Ellerman
2009-05-01 1:56 ` Tim Abbott
2009-05-01 1:56 ` Tim Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241142402.6928.7.camel@concordia \
--to=michael@ellerman.id.au \
--cc=andersk@MIT.EDU \
--cc=jbarnold@MIT.EDU \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sam@ravnborg.org \
--cc=tabbott@MIT.EDU \
--cc=vda.linux@googlemail.com \
--cc=wdaher@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.