From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] improve error messages in grub-setup
Date: Sun, 03 May 2009 00:35:08 -0400 [thread overview]
Message-ID: <1241325308.8745.39.camel@ct> (raw)
In-Reply-To: <20090502111547.GA28211@thorin>
On Sat, 2009-05-02 at 13:15 +0200, Robert Millan wrote:
> This patch improves error messages in grub-setup, and adds a few
> warnings when requested to install in odd layouts.
>
> Since there was no facility to emmit a warning that is always
> visible (regardless of verbosity), but doesn't abort execution,
> I added one (grub_util_warn ()). Is everyone fine with using
> this interface?
I'm fine with the code, but the warnings are quite serious. I think
grub-install should not proceed if there are any warnings unless there
is an option to ignore warnings (e.g. --ignore-warnings or --force).
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-05-03 4:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-02 11:15 [PATCH] improve error messages in grub-setup Robert Millan
2009-05-03 4:35 ` Pavel Roskin [this message]
2009-05-03 16:55 ` Robert Millan
2009-05-03 17:04 ` Pavel Roskin
2009-05-03 20:54 ` Robert Millan
2009-05-03 21:02 ` Pavel Roskin
2009-05-04 16:23 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241325308.8745.39.camel@ct \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.