From: Johannes Berg <johannes@sipsolutions.net>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] add basic support for parsing country information element
Date: Mon, 04 May 2009 17:57:44 +0200 [thread overview]
Message-ID: <1241452664.8683.51.camel@johannes.local> (raw)
In-Reply-To: <1241452364.2903.3.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]
Hi,
> > I've done that now, and pushed it out, but I think the RSN IE printing
> > you added (and I renamed to print_rsn_ie) is missing some input length
> > validation, could you take a look at that please? In particular it takes
> > the count from the IE, but doesn't verify it fits, I think?
>
> I can have a look at it since it is by no means perfect, but at least we
> know have something that allows us to not bother with iwlist.
Certainly. I just don't want to have it crash on an AP that advertises
completely bogus information :)
> Btw. I named it WPA2 on purpose since not everybody using iw will
> understand that it is actually named RSN. In the end it is your call,
> just to let you know why I did it. One of my first patches actually did
> use RSN in it :)
:)
I was going to call it RSN/WPA2 but that was too long for nice
displaying. Now that I think about it though, I think RSN is more
correct because WPA2 certification doesn't include any 11w things which
this will include. I suspect something like WPA3 will be done for that.
Who knows :)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-05-04 15:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 5:09 [PATCH] add basic support for parsing country information element Marcel Holtmann
2009-05-04 7:56 ` Johannes Berg
2009-05-04 7:58 ` Johannes Berg
2009-05-04 8:51 ` Marcel Holtmann
2009-05-04 11:12 ` Johannes Berg
2009-05-04 11:37 ` Johannes Berg
2009-05-04 15:52 ` Marcel Holtmann
2009-05-04 15:57 ` Johannes Berg [this message]
2009-05-04 16:09 ` Marcel Holtmann
2009-05-04 16:17 ` Johannes Berg
2009-05-04 16:28 ` Marcel Holtmann
2009-05-04 7:58 ` Marcel Holtmann
2009-05-04 8:00 ` Johannes Berg
2009-05-04 8:53 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241452664.8683.51.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.