Re: [PATCH] add basic support for parsing country information element

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

On Mon, 2009-05-04 at 09:09 -0700, Marcel Holtmann wrote:

> > Certainly. I just don't want to have it crash on an AP that advertises
> > completely bogus information :)
> 
> if nobody beats me to it, then I will fix this. Just have to deal with
> some other stuff first.

Alright, thanks. Not too pressing I guess. Just should be done before I
cut the next release.

> tried the RSN/WPA2 too, but it is too long :)
> 
> On a different note, what is your preferred coding style for loops?
> 
> 	for (i = 0; i < len; i++) {
> 
> or
> 
> 	for(i=0; i<len-3; i++)
> 
> I was using the latter one since I assumed that is what you want (it is
> not my preferred one). Then I realized that you are using both or that
> something slipped in. Do you want me to send a patch to fix this?

Oh, well, I prefer the former, but some other people put in the latter,
and I didn't really care too much. No need to send a patch though.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]