kobject_set_name() uses GFP_KERNEL

kobject_set_name() uses GFP_KERNEL

[Marcel Holtmann]

Hi Kay,

all the users of kobject_set_name() which includes dev_set_name() are
allocating their memory for the device name with GFP_KERNEL. It is not a
big deal since device_add() does the same. However it is not obvious and
I ran into an issue in the Bluetooth stack where I was setting the
device name from a context that can't sleep. If this behavior is on
purpose, we better add an extra comment in the documentation.

Regards

Marcel

Re: kobject_set_name() uses GFP_KERNEL

[Kay Sievers]

On Tue, May 5, 2009 at 18:21, Marcel Holtmann <marcel@holtmann.org> wrote:
> all the users of kobject_set_name() which includes dev_set_name() are
> allocating their memory for the device name with GFP_KERNEL. It is not a
> big deal since device_add() does the same. However it is not obvious and
> I ran into an issue in the Bluetooth stack where I was setting the
> device name from a context that can't sleep. If this behavior is on
> purpose, we better add an extra comment in the documentation.

It's the entire driver core and kobjects which use GFP_KERNEL, so it
just "happened" for that function too, I guess.

If it helps to documents that, where should it be added? Maybe you can
just send a patch?

Thanks,
Kay