* [PATCH] x86: vm86() defaults to returning VM86_SIGNAL -- make this explicit
@ 2009-05-07 2:27 Samuel Bronson
0 siblings, 0 replies; only message in thread
From: Samuel Bronson @ 2009-05-07 2:27 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86
Cc: linux-kernel, Samuel Bronson
This code has apparently used "0" and not VM86_SIGNAL since Linux
1.1.9, when Linus added VM86_SIGNAL to vm86.h. This patch changes the
code to use the symbolic name.
The magic 0 tripped me up in trying to extend the vm86(2) manpage to
actually explain vm86()'s interface -- my greps for VM86_SIGNAL came up
fruitless.
Signed-off-by: Samuel Bronson <naesten@gmail.com>
---
arch/x86/kernel/vm86_32.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/vm86_32.c b/arch/x86/kernel/vm86_32.c
index d7ac84e..b8035a0 100644
--- a/arch/x86/kernel/vm86_32.c
+++ b/arch/x86/kernel/vm86_32.c
@@ -318,9 +318,9 @@ static void do_sys_vm86(struct kernel_vm86_struct *info, struct task_struct *tsk
}
/*
- * Save old state, set default return value (%ax) to 0
+ * Save old state, set default return value (%ax) to 0 (VM86_SIGNAL)
*/
- info->regs32->ax = 0;
+ info->regs32->ax = VM86_SIGNAL;
tsk->thread.saved_sp0 = tsk->thread.sp0;
tsk->thread.saved_fs = info->regs32->fs;
tsk->thread.saved_gs = get_user_gs(info->regs32);
--
1.6.3.rc3.24.g6ffd5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-05-07 2:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-07 2:27 [PATCH] x86: vm86() defaults to returning VM86_SIGNAL -- make this explicit Samuel Bronson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.