From: Daniel Ribeiro <drwyrm@gmail.com>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: David Brownell <david-b@pacbell.net>,
spi-devel-general <spi-devel-general@lists.sourceforge.net>,
openezx-devel <openezx-devel@lists.openezx.org>,
Ned Forrester <nforrester@whoi.edu>,
linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>
Subject: pxa2xx_spi: fix for SPI_CS_HIGH
Date: Fri, 08 May 2009 10:52:49 -0300 [thread overview]
Message-ID: <1241790769.10342.35.camel@brutus> (raw)
Commit a7bb3909b3293d503211d7f6af8ed62c1644b686 introduces chipselect
GPIO, and configures the CS polarity using SPI_CS_HIGH spi->mode flag,
but the SPI_CS_HIGH is not allowed by setup().
Signed-off-by: Daniel Ribeiro <drwyrm@gmail.com>
diff --git a/drivers/spi/pxa2xx_spi.c b/drivers/spi/pxa2xx_spi.c
index 885194a..150f06b 100644
--- a/drivers/spi/pxa2xx_spi.c
+++ b/drivers/spi/pxa2xx_spi.c
@@ -1186,7 +1186,7 @@ static int transfer(struct spi_device *spi, struct spi_message *msg)
}
/* the spi->mode bits understood by this driver: */
-#define MODEBITS (SPI_CPOL | SPI_CPHA)
+#define MODEBITS (SPI_CPOL | SPI_CPHA | SPI_CS_HIGH)
static int setup_cs(struct spi_device *spi, struct chip_data *chip,
struct pxa2xx_spi_chip *chip_info)
--
Daniel Ribeiro
next reply other threads:[~2009-05-08 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 13:52 Daniel Ribeiro [this message]
2009-05-08 16:33 ` pxa2xx_spi: fix for SPI_CS_HIGH David Brownell
[not found] ` <200905080933.17128.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-05-08 18:46 ` Daniel Ribeiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241790769.10342.35.camel@brutus \
--to=drwyrm@gmail.com \
--cc=david-b@pacbell.net \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=nforrester@whoi.edu \
--cc=openezx-devel@lists.openezx.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.