Re: pxa2xx_spi: fix for SPI_CS_HIGH

[David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>]

On Friday 08 May 2009, Daniel Ribeiro wrote:
> Commit a7bb3909b3293d503211d7f6af8ed62c1644b686 introduces chipselect
> GPIO, and configures the CS polarity using SPI_CS_HIGH spi->mode flag,
> but the SPI_CS_HIGH is not allowed by setup().
> 
> Signed-off-by: Daniel Ribeiro <drwyrm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

This doesn't need to merge before 2.6.31, right?
(That is, is is true that nothing in mainline is
yet *relyings* on CS_HIGH working with this driver?)

Assuming that's true, this patch needs to be updated to
apply properly against modebits changes in the MM tree.


> 
> diff --git a/drivers/spi/pxa2xx_spi.c b/drivers/spi/pxa2xx_spi.c
> index 885194a..150f06b 100644
> --- a/drivers/spi/pxa2xx_spi.c
> +++ b/drivers/spi/pxa2xx_spi.c
> @@ -1186,7 +1186,7 @@ static int transfer(struct spi_device *spi, struct spi_message *msg)
>  }
>  
>  /* the spi->mode bits understood by this driver: */
> -#define MODEBITS (SPI_CPOL | SPI_CPHA)
> +#define MODEBITS (SPI_CPOL | SPI_CPHA | SPI_CS_HIGH)
>  
>  static int setup_cs(struct spi_device *spi, struct chip_data *chip,
>  		    struct pxa2xx_spi_chip *chip_info)
> 
> -- 
> Daniel Ribeiro
> 
> 



------------------------------------------------------------------------------
The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
production scanning environment may not be a perfect world - but thanks to
Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
Series Scanner you'll get full speed at 300 dpi even with all image 
processing features enabled. http://p.sf.net/sfu/kodak-com