All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: status grub2 port of grub-legasy map command
Date: Wed, 13 May 2009 21:51:58 -0400	[thread overview]
Message-ID: <1242265918.21129.27.camel@mj> (raw)
In-Reply-To: <1241883761.22837.97.camel@accesodirecto.casa>

On Sat, 2009-05-09 at 17:42 +0200, Javier Martín wrote:

> OK, I have a good feeling about this version of the patch. Most
> importantly, it still works!!

I have committed your patch after a cleanup.  My changes were following:

grub_drivemap_int13_handler_base and grub_drivemap_int13_handler have
been merged.

grub_drivemap_int13_oldhandler points directly to the ljmp argument
(other GRUB sources do it too, jump look for 0xea).

%si is not used anymore.

Tabs are used consistently in drivemap_int13h.S

Many variables have been renamed.

Constants have been brought to the top level and marked as such.

Logic in uninstall_int13_handler() has been fixed.

Some messages have been clarified.  In particularly, biosdisk is called
osdisk now, as it's what the OS sees.  I was thinking of "payload" or
"loadee" as more generic terms, but it can be confusing to the users.

My check for drivemap with no arguments was wrong, fixed now.

Added missing line ends in all outputs.

Removed INT13H_REBASE and INT13H_TONEWADDR, as they were used only once.

Comments have been improved.

-- 
Regards,
Pavel Roskin



  parent reply	other threads:[~2009-05-14  1:52 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-14  1:03 status grub2 port of grub-legasy map command John Stanley
2009-04-14  7:33 ` Felix Zielcke
2009-04-14  9:21   ` John Stanley
2009-04-14  9:04     ` phcoder
2009-04-15  8:55       ` John Stanley
2009-04-15  9:06         ` phcoder
2009-04-15  9:30           ` John Stanley
2009-04-15  9:34             ` phcoder
2009-04-17 21:20               ` Javier Martín
2009-04-17 21:42                 ` Vladimir Serbinenko
2009-04-17 23:12                 ` John Stanley
2009-04-17 23:46                   ` Vladimir Serbinenko
2009-04-18  0:01                     ` John Stanley
2009-04-18  2:18                       ` Javier Martín
2009-04-18  2:36                         ` Vladimir Serbinenko
2009-05-03  0:02                           ` Javier Martín
2009-05-03  9:17                             ` Vladimir 'phcoder' Serbinenko
2009-05-03 19:45                               ` Pavel Roskin
2009-05-03 20:59                             ` Pavel Roskin
2009-05-03 23:37                               ` Javier Martín
2009-05-04  3:57                                 ` Pavel Roskin
2009-05-06 18:41                                   ` Javier Martín
2009-05-09  9:17                                     ` Vladimir 'phcoder' Serbinenko
2009-05-09 13:27                                       ` Javier Martín
2009-05-09 14:04                                         ` Vladimir 'phcoder' Serbinenko
2009-05-09 15:42                                           ` Javier Martín
2009-05-10 11:47                                             ` Vladimir 'phcoder' Serbinenko
2009-05-10 17:03                                               ` Javier Martín
2009-05-14  1:51                                             ` Pavel Roskin [this message]
2009-05-14  6:49                                               ` Vladimir 'phcoder' Serbinenko
2009-05-14 14:03                                                 ` Pavel Roskin
2009-05-14 15:01                                                   ` Vladimir 'phcoder' Serbinenko
2009-05-14 18:17                                                     ` Pavel Roskin
2009-05-14 18:38                                                       ` Vladimir 'phcoder' Serbinenko
2009-05-15 22:46                                                         ` Javier Martín
2009-05-30 15:28                                                       ` Vladimir 'phcoder' Serbinenko
2009-05-31 10:01                                                         ` Javier Martín
2009-05-31 11:36                                                           ` Vladimir 'phcoder' Serbinenko
2009-05-31 12:48                                                             ` Javier Martín
2009-05-31 16:00                                                               ` Vladimir 'phcoder' Serbinenko
2009-05-31 16:26                                                                 ` Javier Martín
2009-05-31 18:05                                                                   ` Vladimir 'phcoder' Serbinenko
2009-05-31 18:50                                                                     ` Javier Martín
2009-05-31 19:00                                                                       ` Vladimir 'phcoder' Serbinenko
2009-05-31 19:35                                                                 ` Christian Franke
2009-05-31 20:13                                                                   ` Javier Martín
2009-06-01  9:53                                                                     ` Vladimir 'phcoder' Serbinenko
2009-06-01 20:41                                                                       ` Javier Martín
2009-06-01 21:45                                                                         ` Vladimir 'phcoder' Serbinenko
2009-06-04 18:56                                                                           ` Vladimir 'phcoder' Serbinenko
2009-06-05 13:55                                                                           ` Vladimir 'phcoder' Serbinenko
2009-06-05 14:06                                                                             ` Javier Martín
2009-05-14  6:53                                               ` Vladimir 'phcoder' Serbinenko
2009-05-14 14:11                                                 ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242265918.21129.27.camel@mj \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.