From: Petr Tesarik <ptesarik@suse.cz>
To: linux-kernel@vger.kernel.org
Cc: linux-x86_64@vger.kernel.org, mingo@elte.hu, andi@firstfloor.org,
zwane@arm.linux.org.uk, roland@redhat.com
Subject: Re: [PATCH 0/4] x86-64: fix vclock_gettime()
Date: Thu, 14 May 2009 15:17:07 +0200 [thread overview]
Message-ID: <1242307027.19219.6.camel@nathan.suse.cz> (raw)
In-Reply-To: <cover.1242299014.git.ptesarik@suse.cz>
Petr Tesarik píše v Čt 14. 05. 2009 v 15:06 +0200:
> Now, commit cb9e35dce94a1b9c59d46224e8a94377d673e204 removed
> rdtsc_barrier() from that function, and moved it to
> do_vgettimeofday(). AFAICS the same is also needed for
> vgetns(). So far so good, a one-liner should do, shouldn't it?
> No, it won't do.
Just to make things clear. The vDSO had been broken even before Ingo's
commit, but the commit made the .altinstructions section go away from
vDSO, which made the bug kind of disappear.
I could even argue that the synchronization is not even needed, because
this code path gets used rather often, and nobody has complained so far,
but that's probably not the point...
Petr Tesarik
prev parent reply other threads:[~2009-05-14 13:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 13:06 [PATCH 0/4] x86-64: fix vclock_gettime() Petr Tesarik
2009-05-14 12:58 ` Andi Kleen
2009-05-14 13:01 ` Petr Tesarik
2009-05-14 14:02 ` Andi Kleen
2009-05-14 14:27 ` Petr Tesarik
2009-05-14 13:06 ` [PATCH 1/4] x86: Use vdso*-syms.h instead of vdso*-syms.lds Petr Tesarik
2009-05-14 13:06 ` [PATCH 2/4] x86: Cleanup vdso-layout.lds.S Petr Tesarik
2009-05-14 13:06 ` [PATCH 3/4] x86-64: link vDSO into the kernel with relocations Petr Tesarik
2009-05-14 13:07 ` [PATCH 4/4] x86: add rdtsc_barrier() to vgetns() Petr Tesarik
2009-05-14 13:17 ` Petr Tesarik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242307027.19219.6.camel@nathan.suse.cz \
--to=ptesarik@suse.cz \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x86_64@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.