From: Petr Tesarik <ptesarik@suse.cz>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, linux-x86_64@vger.kernel.org,
mingo@elte.hu, zwane@arm.linux.org.uk
Subject: Re: [PATCH 0/4] x86-64: fix vclock_gettime()
Date: Thu, 14 May 2009 16:27:40 +0200 [thread overview]
Message-ID: <1242311260.19219.22.camel@nathan.suse.cz> (raw)
In-Reply-To: <20090514140247.GC10933@one.firstfloor.org>
Andi Kleen píše v Čt 14. 05. 2009 v 16:02 +0200:
> > Sorry, this doesn't work, because the function is inlined. And even if
> > it wasn't, the vDSO must be self-contained by definition. User-space
> > cannot simply call into kernel-space.
>
> Wrong, it can call into vsyscall space.
Ah, yes, you're right. The vsyscall is always mapped and it is a special
case for the instruction replacement code already.
So, is there any reason not to put the rdtsc_barrier() around
vget_cycles() in vread_tsc() ?
Petr Tesarik
next prev parent reply other threads:[~2009-05-14 14:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 13:06 [PATCH 0/4] x86-64: fix vclock_gettime() Petr Tesarik
2009-05-14 12:58 ` Andi Kleen
2009-05-14 13:01 ` Petr Tesarik
2009-05-14 14:02 ` Andi Kleen
2009-05-14 14:27 ` Petr Tesarik [this message]
2009-05-14 13:06 ` [PATCH 1/4] x86: Use vdso*-syms.h instead of vdso*-syms.lds Petr Tesarik
2009-05-14 13:06 ` [PATCH 2/4] x86: Cleanup vdso-layout.lds.S Petr Tesarik
2009-05-14 13:06 ` [PATCH 3/4] x86-64: link vDSO into the kernel with relocations Petr Tesarik
2009-05-14 13:07 ` [PATCH 4/4] x86: add rdtsc_barrier() to vgetns() Petr Tesarik
2009-05-14 13:17 ` [PATCH 0/4] x86-64: fix vclock_gettime() Petr Tesarik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242311260.19219.22.camel@nathan.suse.cz \
--to=ptesarik@suse.cz \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x86_64@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.