From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Ville Syrjälä" <syrjala@sci.fi>
Cc: linux-fbdev-devel@lists.sourceforge.net,
Andrew Morton <akpm@linux-foundation.org>,
Paul Mackerras <paulus@samba.org>,
adaplas@gmail.com
Subject: Re: [PATCH] platinumfb: misplaced parenthesis
Date: Sat, 16 May 2009 08:21:07 +1000 [thread overview]
Message-ID: <1242426067.9691.4.camel@pasglop> (raw)
In-Reply-To: <20090515212449.GD6520@sci.fi>
On Sat, 2009-05-16 at 00:24 +0300, Ville Syrjälä wrote:
> How about just pulling that magic video_mode/cmode handling out of
> that
> single statement so that it could be parsed with less effort?
>
Agreed.
Just store the base value in a variable, then do an if (VMODE/CMODE)
that adds the offset or something like that.
Cheers,
Ben.
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables
unlimited royalty-free distribution of the report engine
for externally facing server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
next prev parent reply other threads:[~2009-05-15 22:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 12:19 [PATCH] staging: misplaced parentheses? Roel Kluin
2009-05-14 16:38 ` Andrew Morton
2009-05-14 23:24 ` Benjamin Herrenschmidt
2009-05-15 10:51 ` Roel Kluin
2009-05-15 20:43 ` [PATCH] platinumfb: misplaced parenthesis Roel Kluin
2009-05-15 21:24 ` Ville Syrjälä
2009-05-15 22:21 ` Benjamin Herrenschmidt [this message]
2009-05-17 11:53 ` Roel Kluin
2009-05-17 17:11 ` Geert Uytterhoeven
2009-05-18 10:23 ` Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242426067.9691.4.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=paulus@samba.org \
--cc=syrjala@sci.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.