Re: [PATCH] platinumfb: misplaced parenthesis

[Roel Kluin <roel.kluin@gmail.com>]

Since `+' has a higher precedence than the trinary operator `?', this
added `hres * (1 << color_mode)' to the boolean testing videomode
and depth.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
 static inline int platinum_vram_reqd(int video_mode, int color_mode)
 {
+	int offset;
+
+	if ((video_mode == VMODE_832_624_75) && (color_mode > CMODE_8))
+		offset = 0x1010;
+	else
+		offset = 0x1020;
+
 	return vmode_attrs[video_mode-1].vres *
-	       (vmode_attrs[video_mode-1].hres * (1<<color_mode) +
-		((video_mode == VMODE_832_624_75) &&
-		 (color_mode > CMODE_8)) ? 0x10 : 0x20) + 0x1000;
+		(vmode_attrs[video_mode-1].hres * (1<<color_mode) + offset);
 }
 
 #define STORE_D2(a, d) { \

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables 
unlimited royalty-free distribution of the report engine 
for externally facing server and web deployment. 
http://p.sf.net/sfu/businessobjects