From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: can't compile r220 because of setjmp.S
Date: Sat, 16 May 2009 19:32:45 +0200 [thread overview]
Message-ID: <1242495165.3701.9.camel@fz.local> (raw)
In-Reply-To: <d7ead6de0905161027j7e49b3c7r1a814ced67e9ee9a@mail.gmail.com>
Am Samstag, den 16.05.2009, 19:27 +0200 schrieb Vladimir 'phcoder'
Serbinenko:
> 2009/5/16 Javier Martín <lordhabbit@gmail.com>:
> > El sáb, 16-05-2009 a las 19:22 +0200, Felix Zielcke escribió:
> >> Am Samstag, den 16.05.2009, 18:52 +0200 schrieb Felix Zielcke:
> >>
> >> > As said on IRC, it seems like the -m32 was missing there, even though it
> >> > should be set through the COMMON_CSFLAGS in i386-pc.rmk.
> >> > But that did the trick in i386.rmk:
> >> >
> >> > -setjmp_mod_CFLAGS = $(COMMON_CFLAGS)
> >> > +setjmp_mod_ASFLAGS = $(COMMON_ASFLAGS)
> >>
> >> Commited this change as Acked-by Vladimir on IRC.
> > You only changed it in i386. Given that a .S file is always "compiled"
> > by the assembler, shouldn't the change be applied to all other platforms
> > too?
> >
> True. I didn't see it was the same mistake in other arches as well. Nice catch
Changed now for the other arches too.
--
Felix Zielcke
next prev parent reply other threads:[~2009-05-16 17:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-16 16:23 can't compile r220 because of setjmp.S Felix Zielcke
2009-05-16 16:34 ` Vladimir 'phcoder' Serbinenko
2009-05-16 16:52 ` Felix Zielcke
2009-05-16 17:22 ` Felix Zielcke
2009-05-16 17:25 ` Javier Martín
2009-05-16 17:27 ` Vladimir 'phcoder' Serbinenko
2009-05-16 17:32 ` Felix Zielcke [this message]
2009-05-16 19:49 ` Bean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242495165.3701.9.camel@fz.local \
--to=fzielcke@z-51.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.