can't compile r220 because of setjmp.S

can't compile r220 because of setjmp.S

[Felix Zielcke]

Hi list,

r2220 on amd64 fails for me with:

cc -Ilib/i386 -I/tmp/buildd/grub2-1.96+20090516/lib/i386 -I. -I./include -I/tmp/buildd/grub2-1.96+20090516/include -Wall -W -DASM_FILE=1   -MD -c -o setjmp_mod-lib_i386_setjmp.o /tmp/buildd/grub2-1.96+20090516/lib/i386/setjmp.S
setjmp.S: Assembler messages:
setjmp.S:33: Error: suffix or operands invalid for `pop'
setjmp.S:37: Error: suffix or operands invalid for `jmp'
setjmp.S:55: Error: suffix or operands invalid for `jmp'

Both with binutils from Debian sid and experimental
GNU assembler version 2.19.1 (x86_64-linux-gnu) using BFD version (GNU Binutils for Debian) 2.19.1
GNU assembler version 2.19.51 (x86_64-linux-gnu) using BFD version (GNU Binutils for Debian) 2.19.51.20090508

I don't know any ASM at all so I can't fix this.
--
Felix Zielcke

Re: can't compile r220 because of setjmp.S

[Vladimir 'phcoder' Serbinenko]

On Sat, May 16, 2009 at 6:23 PM, Felix Zielcke <fzielcke@z-51.de> wrote:
> Hi list,
>
> r2220 on amd64 fails for me with:
>
> cc -Ilib/i386 -I/tmp/buildd/grub2-1.96+20090516/lib/i386 -I. -I./include -I/tmp/buildd/grub2-1.96+20090516/include -Wall -W -DASM_FILE=1   -MD -c -o setjmp_mod-lib_i386_setjmp.o /tmp/buildd/grub2-1.96+20090516/lib/i386/setjmp.S
> setjmp.S: Assembler messages:
> setjmp.S:33: Error: suffix or operands invalid for `pop'
> setjmp.S:37: Error: suffix or operands invalid for `jmp'
> setjmp.S:55: Error: suffix or operands invalid for `jmp'
It tries to compile 32-bit version. You should say it to take 64-bit
one. I have to go to eat now. When I come back if you haven't done it
yet I'll do it
>
> Both with binutils from Debian sid and experimental
> GNU assembler version 2.19.1 (x86_64-linux-gnu) using BFD version (GNU Binutils for Debian) 2.19.1
> GNU assembler version 2.19.51 (x86_64-linux-gnu) using BFD version (GNU Binutils for Debian) 2.19.51.20090508
>
> I don't know any ASM at all so I can't fix this.
> --
> Felix Zielcke
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Re: can't compile r220 because of setjmp.S

[Felix Zielcke]

Am Samstag, den 16.05.2009, 18:34 +0200 schrieb Vladimir 'phcoder'
Serbinenko:
> On Sat, May 16, 2009 at 6:23 PM, Felix Zielcke <fzielcke@z-51.de> wrote:
> > Hi list,
> >
> > r2220 on amd64 fails for me with:
> >
> > cc -Ilib/i386 -I/tmp/buildd/grub2-1.96+20090516/lib/i386 -I. -I./include -I/tmp/buildd/grub2-1.96+20090516/include -Wall -W -DASM_FILE=1   -MD -c -o setjmp_mod-lib_i386_setjmp.o /tmp/buildd/grub2-1.96+20090516/lib/i386/setjmp.S
> > setjmp.S: Assembler messages:
> > setjmp.S:33: Error: suffix or operands invalid for `pop'
> > setjmp.S:37: Error: suffix or operands invalid for `jmp'
> > setjmp.S:55: Error: suffix or operands invalid for `jmp'
> It tries to compile 32-bit version. You should say it to take 64-bit
> one. I have to go to eat now. When I come back if you haven't done it
> yet I'll do it

As said on IRC, it seems like the -m32 was missing there, even though it
should be set through the COMMON_CSFLAGS in i386-pc.rmk.
But that did the trick in i386.rmk:

-setjmp_mod_CFLAGS = $(COMMON_CFLAGS)
+setjmp_mod_ASFLAGS = $(COMMON_ASFLAGS)

-- 
Felix Zielcke

Re: can't compile r220 because of setjmp.S

[Felix Zielcke]

Am Samstag, den 16.05.2009, 18:52 +0200 schrieb Felix Zielcke:

> As said on IRC, it seems like the -m32 was missing there, even though it
> should be set through the COMMON_CSFLAGS in i386-pc.rmk.
> But that did the trick in i386.rmk:
> 
> -setjmp_mod_CFLAGS = $(COMMON_CFLAGS)
> +setjmp_mod_ASFLAGS = $(COMMON_ASFLAGS)

Commited this change as Acked-by Vladimir on IRC.
-- 
Felix Zielcke

Re: can't compile r220 because of setjmp.S

[Javier Martín]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

El sáb, 16-05-2009 a las 19:22 +0200, Felix Zielcke escribió:
> Am Samstag, den 16.05.2009, 18:52 +0200 schrieb Felix Zielcke:
> 
> > As said on IRC, it seems like the -m32 was missing there, even though it
> > should be set through the COMMON_CSFLAGS in i386-pc.rmk.
> > But that did the trick in i386.rmk:
> > 
> > -setjmp_mod_CFLAGS = $(COMMON_CFLAGS)
> > +setjmp_mod_ASFLAGS = $(COMMON_ASFLAGS)
> 
> Commited this change as Acked-by Vladimir on IRC.
You only changed it in i386. Given that a .S file is always "compiled"
by the assembler, shouldn't the change be applied to all other platforms
too?

-- 
-- Lazy, Oblivious, Recurrent Disaster -- Habbit

[-- Attachment #2: Esto es una parte de mensaje firmado digitalmente --]
[-- Type: application/pgp-signature, Size: 835 bytes --]

Re: can't compile r220 because of setjmp.S

[Vladimir 'phcoder' Serbinenko]

2009/5/16 Javier Martín <lordhabbit@gmail.com>:
> El sáb, 16-05-2009 a las 19:22 +0200, Felix Zielcke escribió:
>> Am Samstag, den 16.05.2009, 18:52 +0200 schrieb Felix Zielcke:
>>
>> > As said on IRC, it seems like the -m32 was missing there, even though it
>> > should be set through the COMMON_CSFLAGS in i386-pc.rmk.
>> > But that did the trick in i386.rmk:
>> >
>> > -setjmp_mod_CFLAGS = $(COMMON_CFLAGS)
>> > +setjmp_mod_ASFLAGS = $(COMMON_ASFLAGS)
>>
>> Commited this change as Acked-by Vladimir on IRC.
> You only changed it in i386. Given that a .S file is always "compiled"
> by the assembler, shouldn't the change be applied to all other platforms
> too?
>
True. I didn't see it was the same mistake in other arches as well. Nice catch
> --
> -- Lazy, Oblivious, Recurrent Disaster -- Habbit
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Re: can't compile r220 because of setjmp.S

[Felix Zielcke]

Am Samstag, den 16.05.2009, 19:27 +0200 schrieb Vladimir 'phcoder'
Serbinenko:
> 2009/5/16 Javier Martín <lordhabbit@gmail.com>:
> > El sáb, 16-05-2009 a las 19:22 +0200, Felix Zielcke escribió:
> >> Am Samstag, den 16.05.2009, 18:52 +0200 schrieb Felix Zielcke:
> >>
> >> > As said on IRC, it seems like the -m32 was missing there, even though it
> >> > should be set through the COMMON_CSFLAGS in i386-pc.rmk.
> >> > But that did the trick in i386.rmk:
> >> >
> >> > -setjmp_mod_CFLAGS = $(COMMON_CFLAGS)
> >> > +setjmp_mod_ASFLAGS = $(COMMON_ASFLAGS)
> >>
> >> Commited this change as Acked-by Vladimir on IRC.
> > You only changed it in i386. Given that a .S file is always "compiled"
> > by the assembler, shouldn't the change be applied to all other platforms
> > too?
> >
> True. I didn't see it was the same mistake in other arches as well. Nice catch

Changed now for the other arches too.
-- 
Felix Zielcke

Re: can't compile r220 because of setjmp.S

[Bean]

Hi,

Oh, sorry about the setjmp breakage. BTW, I've written a wiki page on
lua script engine:

http://grub.enbug.org/LUASupport

On Sun, May 17, 2009 at 1:32 AM, Felix Zielcke <fzielcke@z-51.de> wrote:
> Am Samstag, den 16.05.2009, 19:27 +0200 schrieb Vladimir 'phcoder'
> Serbinenko:
>> 2009/5/16 Javier Martín <lordhabbit@gmail.com>:
>> > El sáb, 16-05-2009 a las 19:22 +0200, Felix Zielcke escribió:
>> >> Am Samstag, den 16.05.2009, 18:52 +0200 schrieb Felix Zielcke:
>> >>
>> >> > As said on IRC, it seems like the -m32 was missing there, even though it
>> >> > should be set through the COMMON_CSFLAGS in i386-pc.rmk.
>> >> > But that did the trick in i386.rmk:
>> >> >
>> >> > -setjmp_mod_CFLAGS = $(COMMON_CFLAGS)
>> >> > +setjmp_mod_ASFLAGS = $(COMMON_ASFLAGS)
>> >>
>> >> Commited this change as Acked-by Vladimir on IRC.
>> > You only changed it in i386. Given that a .S file is always "compiled"
>> > by the assembler, shouldn't the change be applied to all other platforms
>> > too?
>> >
>> True. I didn't see it was the same mistake in other arches as well. Nice catch
>
> Changed now for the other arches too.
> --
> Felix Zielcke
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Bean