From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] ata.mod under qemu
Date: Wed, 20 May 2009 18:13:00 -0400 [thread overview]
Message-ID: <1242857580.2555.2.camel@mj> (raw)
In-Reply-To: <4A1478C1.5000906@t-online.de>
On Wed, 2009-05-20 at 23:40 +0200, Christian Franke wrote:
> The attached patch should fix this. It should also prevents misleading
> error messages if a device does not exist.
>
> 2009-05-20 Christian Franke <franke@computer.org>
>
> * disk/ata.c: (grub_ata_wait_not_busy): Add debug output of status
> register.
> (grub_ata_identify): Suppress error message if status register
> is 0x00 after command failure.
> (grub_device_initialize): Remove unsafe status register check.
> Thanks to 'phcoder' for problem report and patch.
> Prevent sign extension in debug message.
It helps detect CD-ROM under qemu. But on the real hardware, it
introduces ghost drives.
Without the patch, I have (ata7) for the SATA hard drive. With the
patch, I have (ata7) for the SATA hard drive, (ata6) for the SATA DVD-RW
and two bogus unreadable drives (ata0) and (ata1).
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-05-20 22:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 17:59 [PATCH] ata.mod under qemu Vladimir 'phcoder' Serbinenko
2009-05-18 17:59 ` Vladimir 'phcoder' Serbinenko
2009-05-18 18:04 ` Vladimir 'phcoder' Serbinenko
2009-05-18 23:36 ` Pavel Roskin
2009-05-19 0:17 ` Pavel Roskin
2009-05-19 13:12 ` Christian Franke
2009-05-20 21:40 ` Christian Franke
2009-05-20 22:13 ` Pavel Roskin [this message]
2009-05-21 20:59 ` Christian Franke
2009-05-23 21:04 ` Christian Franke
2009-05-24 7:07 ` Pavel Roskin
2009-05-25 19:47 ` Christian Franke
2009-05-25 20:03 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242857580.2555.2.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.