From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/lockdep: report the time waited for a lock
Date: Thu, 28 May 2009 16:34:43 +0200 [thread overview]
Message-ID: <1243521283.6645.0.camel@laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.0905281032010.27708@gandalf.stny.rr.com>
On Thu, 2009-05-28 at 10:32 -0400, Steven Rostedt wrote:
> > + TP_STRUCT__entry(
> > + __field(const char *, name)
> > + __field(unsigned long, wait_usec)
> > + __field(unsigned long, wait_nsec_rem)
> > + ),
> > + TP_fast_assign(
> > + __entry->name = lock->name;
> > + __entry->wait_nsec_rem = do_div(waittime, NSEC_PER_USEC);
>
> I know this is already accepted, but can you move the do_div into the
> print section.
please do. Just fold those wait_* fields into a single u64 nsec one.
next prev parent reply other threads:[~2009-05-28 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-05 23:49 [PATCH] tracing/lockdep: report the time waited for a lock Frederic Weisbecker
2009-04-10 11:07 ` [tip:tracing/core] " Frederic Weisbecker
2009-05-28 14:32 ` [PATCH] " Steven Rostedt
2009-05-28 14:34 ` Peter Zijlstra [this message]
2009-05-28 14:39 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243521283.6645.0.camel@laptop \
--to=peterz@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.