Re: [PATCH] tracing/lockdep: report the time waited for a lock

[Frederic Weisbecker <fweisbec@gmail.com>]

On Thu, May 28, 2009 at 04:34:43PM +0200, Peter Zijlstra wrote:
> On Thu, 2009-05-28 at 10:32 -0400, Steven Rostedt wrote:
> 
> > > +	TP_STRUCT__entry(
> > > +		__field(const char *, name)
> > > +		__field(unsigned long, wait_usec)
> > > +		__field(unsigned long, wait_nsec_rem)
> > > +	),
> > > +	TP_fast_assign(
> > > +		__entry->name = lock->name;
> > > +		__entry->wait_nsec_rem = do_div(waittime, NSEC_PER_USEC);
> > 
> > I know this is already accepted, but can you move the do_div into the 
> > print section.
> 
> please do. Just fold those wait_* fields into a single u64 nsec one.


Indeed, I'll fix it. Thanks!