From: Peter Zijlstra <peterz@infradead.org>
To: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] perf_counter: Don't swap contexts containing locked mutex
Date: Fri, 29 May 2009 10:10:44 +0200 [thread overview]
Message-ID: <1243584644.23657.164.camel@twins> (raw)
In-Reply-To: <1243584388.23657.156.camel@twins>
On Fri, 2009-05-29 at 10:06 +0200, Peter Zijlstra wrote:
> > @@ -919,7 +919,8 @@ static int context_equiv(struct perf_counter_context *ctx1,
> > struct perf_counter_context *ctx2)
> > {
> > return ctx1->parent_ctx && ctx1->parent_ctx == ctx2->parent_ctx
> > - && ctx1->parent_gen == ctx2->parent_gen;
> > + && ctx1->parent_gen == ctx2->parent_gen
> > + && ctx1->parent_gen != ~0ull;
> > }
>
> There's a nasty surprise for people a few generations down the line. All
> of a sudden performance drops for a while for some unknown reason, and
> then its good again,.. how odd ;-)
OK, so I was joking, but my brain just came up with:
static void inc_generation(struct perf_counter_ctx *ctx)
{
ctx->generation = ++ctx->generation & 0x7FFFFFFFFFFFFFFF;
}
next prev parent reply other threads:[~2009-05-29 8:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 6:06 [PATCH RFC] perf_counter: Don't swap contexts containing locked mutex Paul Mackerras
2009-05-29 8:06 ` Peter Zijlstra
2009-05-29 8:10 ` Peter Zijlstra [this message]
2009-05-29 8:13 ` Peter Zijlstra
2009-05-29 8:28 ` Peter Zijlstra
2009-05-29 8:59 ` Ingo Molnar
2009-05-29 9:16 ` Ingo Molnar
2009-05-29 11:13 ` Paul Mackerras
2009-05-29 11:17 ` Peter Zijlstra
2009-05-29 11:23 ` Paul Mackerras
2009-05-29 12:35 ` Ingo Molnar
2009-05-29 13:49 ` Pekka Enberg
2009-05-29 8:25 ` Paul Mackerras
2009-05-29 12:03 ` [tip:perfcounters/core] " tip-bot for Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243584644.23657.164.camel@twins \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.