From: Peter Zijlstra <peterz@infradead.org>
To: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] perf_counter: Don't swap contexts containing locked mutex
Date: Fri, 29 May 2009 13:17:30 +0200 [thread overview]
Message-ID: <1243595850.23657.213.camel@twins> (raw)
In-Reply-To: <18975.50009.814331.113052@cargo.ozlabs.ibm.com>
On Fri, 2009-05-29 at 21:13 +1000, Paul Mackerras wrote:
> Ingo Molnar writes:
>
> > looping in the remove-context retry loop.
>
> Ah! We need to reload task inside the loop. And possibly in other
> places.
Thing is, after your patch this is called after the unclone, so the
context should be stable, still we see this. But yeah that loop needs
some care.
I also noticed we have races on cpuctx->task_ctx, I was looking at
removing it alltogether in favour of current->perf_counter_ctxp.
next prev parent reply other threads:[~2009-05-29 11:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 6:06 [PATCH RFC] perf_counter: Don't swap contexts containing locked mutex Paul Mackerras
2009-05-29 8:06 ` Peter Zijlstra
2009-05-29 8:10 ` Peter Zijlstra
2009-05-29 8:13 ` Peter Zijlstra
2009-05-29 8:28 ` Peter Zijlstra
2009-05-29 8:59 ` Ingo Molnar
2009-05-29 9:16 ` Ingo Molnar
2009-05-29 11:13 ` Paul Mackerras
2009-05-29 11:17 ` Peter Zijlstra [this message]
2009-05-29 11:23 ` Paul Mackerras
2009-05-29 12:35 ` Ingo Molnar
2009-05-29 13:49 ` Pekka Enberg
2009-05-29 8:25 ` Paul Mackerras
2009-05-29 12:03 ` [tip:perfcounters/core] " tip-bot for Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243595850.23657.213.camel@twins \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.