[PATCH] sdhci: consider ADMA error interrupt as data interrupt

[PATCH] sdhci: consider ADMA error interrupt as data interrupt

[Ben Dooks]

Currently any SDHCI_INT_ADMA_ERROR response is processed by
sdhci_data_irq() producing an -EIO for the transfer, but is
not in the SDHCI_INT_DATA_MASK so sdhci_irq() produces a
warning of "Unexpected interrupt 0x02000000".

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
---
 drivers/mmc/host/sdhci.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index f20a834..c9dd8bf 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -125,7 +125,7 @@
 #define  SDHCI_INT_DATA_MASK	(SDHCI_INT_DATA_END | SDHCI_INT_DMA_END | \
 		SDHCI_INT_DATA_AVAIL | SDHCI_INT_SPACE_AVAIL | \
 		SDHCI_INT_DATA_TIMEOUT | SDHCI_INT_DATA_CRC | \
-		SDHCI_INT_DATA_END_BIT)
+		SDHCI_INT_DATA_END_BIT | SDHCI_INT_ADMA_ERROR)
 #define SDHCI_INT_ALL_MASK	((unsigned int)-1)
 
 #define SDHCI_ACMD12_ERR	0x3C
-- 
1.5.6.5

Re: [PATCH] sdhci: consider ADMA error interrupt as data interrupt

[Pierre Ossman]

[-- Attachment #1: Type: text/plain, Size: 727 bytes --]

On Fri, 29 May 2009 14:35:59 +0100
Ben Dooks <ben-linux@fluff.org> wrote:

> Currently any SDHCI_INT_ADMA_ERROR response is processed by
> sdhci_data_irq() producing an -EIO for the transfer, but is
> not in the SDHCI_INT_DATA_MASK so sdhci_irq() produces a
> warning of "Unexpected interrupt 0x02000000".
> 
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=4accfe2577fab83e41db02282570e849f24ddf53

;)

Rgds
-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]