All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: making the --no-floopy option of grub-install more descriptive
Date: Fri, 29 May 2009 12:27:45 -0400	[thread overview]
Message-ID: <1243614465.12433.21.camel@mj> (raw)
In-Reply-To: <1243598750.3544.9.camel@fz.local>

On Fri, 2009-05-29 at 14:05 +0200, Felix Zielcke wrote:
> Hi,
> 
> on a Debian bug report [0] someone complained that the --no-floppy
> option should be better documented in the man page, because it only
> works if device.map doestn't exist or --recheck is given and he was
> confused of this.

For --no-floppy not to work, grub-install would have to probe the floppy
when --no-floppy is used.  I don't see the evidence of it happening.

> But it's generated from the --help output and I'm not that sure to make
> it longer.
> Or would something like this be okay?
> 
> Index: util/i386/pc/grub-install.in
> ===================================================================
> --- util/i386/pc/grub-install.in	(revision 2237)
> +++ util/i386/pc/grub-install.in	(working copy)
> @@ -65,7 +65,8 @@ Install GRUB on your drive.
>    --grub-mkimage=FILE     use FILE as grub-mkimage
>    --grub-mkdevicemap=FILE use FILE as grub-mkdevicemap
>    --grub-probe=FILE       use FILE as grub-probe
> -  --no-floppy             do not probe any floppy drive
> +  --no-floppy             do not probe any floppy drive. Works only if
> +                          device.map doestn't exit or --recheck is
> given

First of all, please check spelling of your patches.

Many options in many programs have effect only if some other options are
used or not used.  It's a minor technical detail.  Such details may
belong to manuals, but perhaps not at this stage of development.  In my
opinion, the whole idea of probing all hardware in the system is broken.
grub-install cannot predict how BIOS would see the devices.  So
"--no-floppy" can go away before the next stable release.

We could reverse the logic and not probe floppies by default.  But I'm
not sure it's worth the trouble.

We really need to support installation on non-probed devices.  Then we
can limit the probing to the cases when it's explicitly requested.

-- 
Regards,
Pavel Roskin



      reply	other threads:[~2009-05-29 16:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-29 12:05 making the --no-floopy option of grub-install more descriptive Felix Zielcke
2009-05-29 16:27 ` Pavel Roskin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1243614465.12433.21.camel@mj \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.