From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] add true and false commands
Date: Fri, 05 Jun 2009 10:47:03 +0200 [thread overview]
Message-ID: <1244191623.3416.1.camel@fz.local> (raw)
In-Reply-To: <874ouwcst9.fsf@xs4all.nl>
Am Donnerstag, den 04.06.2009, 10:21 +0200 schrieb Marco Gerards:
> Felix Zielcke <fzielcke@z-51.de> writes:
>
> > Am Montag, den 01.06.2009, 16:24 +0200 schrieb Vladimir 'phcoder'
> > Serbinenko:
> >> However convention for
> >> creating false is:
> >> return grub_error (GRUB_ERR_TEST_FAILURE, "false");
> >> and not
> >> return 1;
> >
> > Ok changed it. If everyone is fine with placing this in normal/main.c, I
> > commit it.
>
> Unless it is essential to do so, please do not place it in
> normal/main.c.
>
would normal/misc.c be okay or maybe a new file normal/true.c?
I just don't think it's worth to create a new module for these 2 very
little commands.
--
Felix Zielcke
next prev parent reply other threads:[~2009-06-05 8:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 12:16 [PATCH] add true and false commands Felix Zielcke
2009-05-30 15:14 ` Vladimir 'phcoder' Serbinenko
2009-06-01 14:18 ` Felix Zielcke
2009-06-01 14:24 ` Vladimir 'phcoder' Serbinenko
2009-06-03 15:45 ` Felix Zielcke
2009-06-04 8:21 ` Marco Gerards
2009-06-05 8:47 ` Felix Zielcke [this message]
2009-06-05 10:00 ` Marco Gerards
2009-06-05 10:32 ` Felix Zielcke
2009-06-05 12:26 ` Marco Gerards
2009-06-05 13:04 ` Felix Zielcke
2009-06-05 13:29 ` Marco Gerards
2009-06-05 15:56 ` Felix Zielcke
2009-06-08 7:32 ` Felix Zielcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244191623.3416.1.camel@fz.local \
--to=fzielcke@z-51.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.