All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] support of hfsx ( case comparaison )
Date: Fri, 05 Jun 2009 17:08:55 -0400	[thread overview]
Message-ID: <1244236135.10875.9.camel@mj> (raw)
In-Reply-To: <1244229804.4857.154.camel@akroma.ephaone.org>

On Fri, 2009-06-05 at 21:23 +0200, Michael Scherer wrote:

> Ok, I have taken in account your remark. Here is another patch.

I've applied your patch with two fixes.  Somehow you interchanged the
values of GRUB_HFSPLUSX_BINARYCOMPARE and GRUB_HFSPLUSX_CASEFOLDING.
GRUB_HFSPLUSX_BINARYCOMPARE is 0xBC and GRUB_HFSPLUSX_CASEFOLDING is
0xCF.  The values are actually abbreviations.

I wonder if you have tested your patch.  I have tested the final patch
on both case-sensitive and case-insensitive filesystems, and it appears
to be OK.

Also, it should not be needed to call an inline function from
grub_hfsplus_iterate_dir().  It's easier to calculate it once for the
filesystem at the mount time.

-- 
Regards,
Pavel Roskin



      parent reply	other threads:[~2009-06-05 21:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-12 21:52 [PATCH] support of hfsx ( case comparaison ) Michael Scherer
2009-02-07 21:02 ` Robert Millan
2009-05-03 17:19   ` Michael Scherer
2009-06-01 10:11     ` Vladimir 'phcoder' Serbinenko
2009-06-03  7:56       ` Michael Scherer
2009-06-03  9:26         ` Vladimir 'phcoder' Serbinenko
2009-06-03 10:54           ` Michael Scherer
2009-06-03 21:23             ` Pavel Roskin
2009-06-05 19:23               ` Michael Scherer
2009-06-05 19:46                 ` Vladimir 'phcoder' Serbinenko
2009-06-07  2:18                   ` Pavel Roskin
2009-06-07  9:10                     ` Vladimir 'phcoder' Serbinenko
2009-06-07 17:40                       ` Pavel Roskin
2009-06-05 21:08                 ` Pavel Roskin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244236135.10875.9.camel@mj \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.