From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] add drivemap support to 30_os-prober.in and use UUIDs
Date: Sun, 07 Jun 2009 11:55:52 -0400 [thread overview]
Message-ID: <1244390152.27559.13.camel@mj> (raw)
In-Reply-To: <1244389079.3791.7.camel@fz.local>
On Sun, 2009-06-07 at 17:37 +0200, Felix Zielcke wrote:
> Attached patch uses `prepare_grub_to_access_device' to set the root in
> the generated entrys.
> And it adds drivemap to the chainload ones, if root isn't (hd0).
>
> The Debian grub-installer adds map only with Dos and Windows, should I
> do the same or is it okay to do it for all?
Perhaps it would be better to avoid it when it's not needed. But it may
be tricky to determine what bootloader we are using.
Let's do it always and eliminate the cases where it's harmful or
definitely useless.
> -# update-grub helper script.
> +# grub-mkconfig helper script.
> Does this needs to be mentioned in ChangeLog?
The standard says:
'When you change just comments or doc strings, it is enough to write
an entry for the file, without mentioning the functions. Just "Doc
fixes" is enough for the change log.'
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-06-07 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-07 15:37 [PATCH] add drivemap support to 30_os-prober.in and use UUIDs Felix Zielcke
2009-06-07 15:55 ` Pavel Roskin [this message]
2009-06-08 10:54 ` Vladimir 'phcoder' Serbinenko
2009-06-09 20:21 ` Felix Zielcke
2009-06-09 20:34 ` Pavel Roskin
2009-06-11 19:00 ` Felix Zielcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244390152.27559.13.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.