From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] drivemap fixes
Date: Sun, 07 Jun 2009 22:10:41 -0400 [thread overview]
Message-ID: <1244427041.2690.10.camel@mj> (raw)
In-Reply-To: <d7ead6de0906050727t9095bd7y801a8e317559648f@mail.gmail.com>
On Fri, 2009-06-05 at 16:27 +0200, Vladimir 'phcoder' Serbinenko wrote:
> Hello. As suggested by Javier Martín I move this to a new thread. This
> patch fixes some problems with determining bios number of a disk.
> biosnum is in boot.mod because it's where it will cause the least of
> possible core.img increase (3 of 5 loaders on pc need biosnum).
> Thisforced to move boot.mod to platform-specific files but this
> inflexibility of build system is a subject for another patch
I'll appreciate if you also provide ChangeLog. Also, it would be great
if you specify, which exactly problems the patch fixes.
As for the fixes to the handler, I think they should be submitted
separately. Please avoid non-words like "postamble". Comments would be
nice. I would try to avoid having two long calls if possible.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-06-08 2:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 14:27 [PATCH] drivemap fixes Vladimir 'phcoder' Serbinenko
2009-06-08 2:10 ` Pavel Roskin [this message]
2009-06-08 11:40 ` Vladimir 'phcoder' Serbinenko
2009-06-11 16:14 ` Vladimir 'phcoder' Serbinenko
2009-06-12 5:58 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244427041.2690.10.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.