Re: [PATCH] add a --disk-module option to grub-install

[Felix Zielcke <fzielcke@z-51.de>]

Am Freitag, den 05.06.2009, 23:26 +0200 schrieb Vladimir 'phcoder'
Serbinenko:
> -        # generic method (used on coreboot)
> +    if [ "$disk_module" = ata ] ; then
> +        # generic method (used on coreboot and ata mod)
>          uuid="`$grub_probe --target=fs_uuid --device ${grub_device}`"
>          if [ "x${uuid}" = "x" ] ; then
> -          echo "UUID needed on this platform, but the filesystem
> containing ${grubdir} does not support UUIDs." 1>&2
> +          echo "UUID needed on this platform and with ata mod, but
> the filesystem containing ${grubdir} does not support UUIDs." 1>&2
> IMO it would be better to remove "on this platform" part.
> Otherwise patch looks ok, I will test it tomorrow

Commited with it removed.

> On Thu, Jun 4, 2009 at 11:07 PM, Felix Zielcke<fzielcke@z-51.de> wrote:
> > Am Donnerstag, den 04.06.2009, 20:57 +0200 schrieb Felix Zielcke:
> >> Here's a patch which adds --disk-module to grub-install for i386-pc to
> >> make it easier for users to try out ata mod instead of biosdisk.
> >
> > Args I forgot the actual parsing of the option.

-- 
Felix Zielcke