Re: [PATCH 1/4] ASoC: pxa-ssp: enhance I2S and add Left_J support

From: Daniel Ribeiro <drwyrm@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Eric Miao <eric.y.miao@gmail.com>,
	linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
	pHilipp Zabel <philipp.zabel@gmail.com>
Subject: Re: [PATCH 1/4] ASoC: pxa-ssp: enhance I2S and add Left_J support
Date: Mon, 08 Jun 2009 17:52:29 -0300	[thread overview]
Message-ID: <1244494349.17327.174.camel@brutus> (raw)
In-Reply-To: <20090608180656.GH7858@sirena.org.uk>

[-- Attachment #1.1: Type: text/plain, Size: 1066 bytes --]

Em Seg, 2009-06-08 às 19:06 +0100, Mark Brown escreveu:
> Think about TDM mode for a minute here - there a separate configuration
> for the sample size on the wire opens the way to using a lower sample
> size in a given timeslot than the timeslot supports, reducing the need
> for the CPU to rewrite data.  Or to put it another way, I can't see TDM
> mode working unless the sample size is constrained to always be exactly
> that desired so it seems sensible to have a standard way of doing that.

Hum... Now I understood this. If i want to use network mode with 2
different codecs, and they differ on the expected frame_size i have to
use the smaller frame_size for both codecs.

And indeed, in this case the best place to setup the frame size would be
on set_tdm_slot().

> I'd rather come up with a cleaner way of configuring the magician case
> that's explicit about what it's trying to achieve.  It doesn't need to
> be in user space, though.

I dont know how to do this other than just changing the frame size... :)

-- 
Daniel Ribeiro

[-- Attachment #1.2: Esta é uma parte de mensagem assinada digitalmente --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel