Re: [PATCH 1/4] ASoC: pxa-ssp: enhance I2S and add Left_J support

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Fri, Jun 05, 2009 at 07:26:30PM +0200, Daniel Mack wrote:

> Ah - the PXA_SSP_FRM_64FS is the detail I missed. With that option set,
> my system works well, so I'm generally fine with the changes.
> 
> However, I proposed a generic way (not pxa/ssp specific) to let the
> format flags carry the information about such frame format details some
> months ago and the approach was rejected because there are already too
> many ways to let the DAI know about this.

Indeed, and there's some potential lack of clarity with the interaction
of settings in the DAI format with these other settings.

>                                           In particular, the DIV_SCR
> (serial clock rate divider) is used to propagate the base frequency
> ratio and together with other options, you can find out the desired
> frame format.

There's that, and there's also the TDM settings which provide
essentially the same information - an overclocked bit clock is
equivalent to a TDM mode where the first slot is in use.  It's not
immediately clear to me what a combination of the two options ought to
do.

It's also a logically different bit of configuration - for most devices
it only makes a difference to the device that's generating the clocks
and wouldn't need to be specified for the other devices since they'd
just ignore the extra clocks.  The DAI format specifies the format for
the clocks, primarily the frame clocks, but does not currently handle
their rates.

> handles the case. Eventually this might be a matter of taste, but if we
> go this way, why shouldn't that definitions be in ASoC's generic
> headers?

Definitely.